Skip to content

Conversation

goderbauer
Copy link
Contributor

This allows us to remove the boilerplate to set up aLogger for the FfiGenerator.

Follow-up to #2694

Copy link

github-actions bot commented Oct 14, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
code_assets None 0.19.8 0.19.8 0.19.8 ✔️
hooks None 0.20.4 0.20.4 0.20.4 ✔️
hooks_runner None 0.23.1 0.23.1 0.23.1 ✔️
objective_c Breaking 8.1.0 9.0.0-dev.0 9.0.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
objective_c _FinalizablePointer internal.dart::_ObjCReference::new::_finalizable

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Oct 14, 2025

Coverage Status

coverage: 82.903%. remained the same
when pulling 8fc6a26 on goderbauer:migrateexamples
into d11195c on dart-lang:main.

@dcharkes
Copy link
Collaborator

FFIgen and the hooks packages are not in a single pub workspace. So you'll need to publish FFIgen first. Once Dart 3.10 is out, we should be able to make it a single workspace.

Usually you get a message on your PR with a GitHub link to create a new release+tag. But I don't see any on #2694.

Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once green

@goderbauer goderbauer merged commit 81ff644 into dart-lang:main Oct 15, 2025
32 checks passed
@goderbauer goderbauer deleted the migrateexamples branch October 15, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants