[jni] Fix jni Android Gradle space-assignment deprecations#3348
[jni] Fix jni Android Gradle space-assignment deprecations#3348ancient0328 wants to merge 1 commit intodart-lang:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with
API leaks
|
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| jni | $JIterator | core_bindings.dart::JIterator::implementIn::$impl core_bindings.dart::JIterator::implement::$impl |
| jni | $JCollection | core_bindings.dart::JCollection::implementIn::$impl core_bindings.dart::JCollection::implement::$impl |
| jni | $JList | core_bindings.dart::JList::implementIn::$impl core_bindings.dart::JList::implement::$impl |
| jni | $JMap$JEntry | core_bindings.dart::JMap$JEntry::implementIn::$impl core_bindings.dart::JMap$JEntry::implement::$impl |
| jni | $JMap | core_bindings.dart::JMap::implementIn::$impl core_bindings.dart::JMap::implement::$impl |
| jni | $JSet | core_bindings.dart::JSet::implementIn::$impl core_bindings.dart::JSet::implement::$impl |
This check can be disabled by tagging the PR with skip-leaking-check.
|
Looks fine to me, but you'll need to sign the CLA |
This PR updates
pkgs/jni/android/build.gradleto use explicit Groovy property assignment syntax.Changed only
pkgs/jni/android/build.gradle:group '...'->group = '...'version '...'->version = '...'namespace '...'->namespace = '...'compileSdk 35->compileSdk = 35ndkVersion flutter.ndkVersion->ndkVersion = flutter.ndkVersionminSdk 21->minSdk = 21No Dart, Java, Kotlin, native runtime, public API, or dependency behavior is intended to change.
This follows Gradle's upgrade guide for Groovy space-assignment deprecations, which are scheduled for removal in Gradle 10.
Related issue: #3347
Reference: https://docs.gradle.org/current/userguide/upgrading_version_8.html#groovy_space_assignment_syntax