Skip to content

[jni] Fix jni Android Gradle space-assignment deprecations#3348

Open
ancient0328 wants to merge 1 commit intodart-lang:mainfrom
ancient0328:hugmedo/gradle-space-assignment-jni-v1
Open

[jni] Fix jni Android Gradle space-assignment deprecations#3348
ancient0328 wants to merge 1 commit intodart-lang:mainfrom
ancient0328:hugmedo/gradle-space-assignment-jni-v1

Conversation

@ancient0328
Copy link
Copy Markdown

This PR updates pkgs/jni/android/build.gradle to use explicit Groovy property assignment syntax.

Changed only pkgs/jni/android/build.gradle:

  • group '...' -> group = '...'
  • version '...' -> version = '...'
  • namespace '...' -> namespace = '...'
  • compileSdk 35 -> compileSdk = 35
  • ndkVersion flutter.ndkVersion -> ndkVersion = flutter.ndkVersion
  • minSdk 21 -> minSdk = 21

No Dart, Java, Kotlin, native runtime, public API, or dependency behavior is intended to change.

This follows Gradle's upgrade guide for Groovy space-assignment deprecations, which are scheduled for removal in Gradle 10.

Related issue: #3347

Reference: https://docs.gradle.org/current/userguide/upgrading_version_8.html#groovy_space_assignment_syntax

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 6, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@liamappelbe liamappelbe self-assigned this May 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
jni None 1.0.0 1.0.1-wip 1.0.1-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
jni $JIterator core_bindings.dart::JIterator::implementIn::$impl
core_bindings.dart::JIterator::implement::$impl
jni $JCollection core_bindings.dart::JCollection::implementIn::$impl
core_bindings.dart::JCollection::implement::$impl
jni $JList core_bindings.dart::JList::implementIn::$impl
core_bindings.dart::JList::implement::$impl
jni $JMap$JEntry core_bindings.dart::JMap$JEntry::implementIn::$impl
core_bindings.dart::JMap$JEntry::implement::$impl
jni $JMap core_bindings.dart::JMap::implementIn::$impl
core_bindings.dart::JMap::implement::$impl
jni $JSet core_bindings.dart::JSet::implementIn::$impl
core_bindings.dart::JSet::implement::$impl

This check can be disabled by tagging the PR with skip-leaking-check.

@liamappelbe liamappelbe changed the title Fix jni Android Gradle space-assignment deprecations [jni] Fix jni Android Gradle space-assignment deprecations May 6, 2026
@liamappelbe
Copy link
Copy Markdown
Contributor

Looks fine to me, but you'll need to sign the CLA

@liamappelbe liamappelbe self-requested a review May 7, 2026 03:08
@liamappelbe liamappelbe removed their assignment May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants