Skip to content

Commit 4ad9268

Browse files
srawlinsCommit Queue
authored andcommitted
analyzer: Test that missing_override_of_must_be_overridden works with DeCo
Work towards #62254 Change-Id: Ic1284f70ba535099de673f7f25ddb34b4e09e6bb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/475268 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
1 parent 7c60da7 commit 4ad9268

1 file changed

Lines changed: 39 additions & 0 deletions

File tree

pkg/analyzer/test/src/diagnostics/missing_override_of_must_be_overridden_test.dart

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,19 @@ class B extends A {}
3737
);
3838
}
3939

40+
test_field_declaredInPrimaryConstructor() async {
41+
await assertErrorsInCode(
42+
'''
43+
import 'package:meta/meta.dart';
44+
45+
class A(@mustBeOverridden var int f);
46+
47+
class B(super.f) extends A {}
48+
''',
49+
[error(diag.missingOverrideOfMustBeOverriddenOne, 79, 1)],
50+
);
51+
}
52+
4053
test_field_method() async {
4154
await assertErrorsInCode(
4255
'''
@@ -78,6 +91,19 @@ class B extends A {
7891
''');
7992
}
8093

94+
test_field_overriddenWithField_inPrimaryConstructor() async {
95+
await assertNoErrorsInCode('''
96+
import 'package:meta/meta.dart';
97+
98+
class A {
99+
@mustBeOverridden
100+
int f = 0;
101+
}
102+
103+
class B(var int f) extends A;
104+
''');
105+
}
106+
81107
test_field_overriddenWithGetterSetterPair() async {
82108
await assertNoErrorsInCode('''
83109
import 'package:meta/meta.dart';
@@ -159,6 +185,19 @@ class B extends A {
159185
''');
160186
}
161187

188+
test_getter_overriddenWithField_inPrimaryConstructor() async {
189+
await assertNoErrorsInCode('''
190+
import 'package:meta/meta.dart';
191+
192+
class A {
193+
@mustBeOverridden
194+
int get f => 0;
195+
}
196+
197+
class B(var int f) extends A;
198+
''');
199+
}
200+
162201
test_getter_overriddenWithGetter() async {
163202
await assertNoErrorsInCode('''
164203
import 'package:meta/meta.dart';

0 commit comments

Comments
 (0)