Skip to content

Comments

Exposing Request object in logger#497

Open
busslina wants to merge 4 commits intodart-lang:masterfrom
busslina:master
Open

Exposing Request object in logger#497
busslina wants to merge 4 commits intodart-lang:masterfrom
busslina:master

Conversation

@busslina
Copy link

@busslina busslina commented Jan 15, 2026

It exposes the Request object into logRequests's optional logger. It can be useful for example to print the IP, ...

The Response object could be also exposed, but I didn't need it for now.

@google-cla
Copy link

google-cla bot commented Jan 15, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@busslina
Copy link
Author

Seems this new logger signature is breaking some "things" so I will revert it and use Zone instead.

I don't like to use Zone if not needed but...

I have bad memories with python's Flask with a similar mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant