Skip to content

Update download_archive code to compile with WebAssembly, too #6653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Jun 7, 2025

No description provided.

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit a380d8b):

https://dart-dev--pr6653-archive-wasm-lctmj0xu.web.app

@kevmoo kevmoo requested review from parlough and sfshaza2 June 9, 2025 19:37
@antfitch antfitch assigned antfitch and unassigned antfitch Jun 9, 2025
@antfitch antfitch requested review from antfitch and removed request for antfitch and sfshaza2 June 9, 2025 22:55
@antfitch
Copy link
Collaborator

antfitch commented Jun 9, 2025

@parlough I feel strongly that you need to review this.

@kevmoo
Copy link
Member Author

kevmoo commented Jun 9, 2025

@parlough I feel strongly that you need to review this.

LOL! Yeah, this is some pretty geeky stuff. @parlough will get it...I'm pretty sure...

@kevmoo
Copy link
Member Author

kevmoo commented Jun 9, 2025

CC @mit-mit @vsmenon @mkustermann @osa1 – dart2wasm on dart.dev

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well to me, thanks @kevmoo!

I'll be exploring integrating this component with a larger Jaspr setup soon, so hopefully will have more components to try this with soon :)

@kevmoo kevmoo merged commit f66c547 into main Jun 10, 2025
11 checks passed
@parlough parlough deleted the archive_wasm branch June 10, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants