Skip to content

Move analytics values into variables. #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
Merged

Conversation

antfitch
Copy link
Collaborator

I've moved the analytics values into variables in site.yml. This now matches what we do on the Flutter side of things.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

@antfitch antfitch requested a review from parlough June 10, 2025 00:07
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jun 10, 2025

Visit the preview URL for this PR (updated for commit 5ef18c9):

https://dart-dev--pr6654-google-analytics-add-variables-q9fzotlf.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for consolidating these.

Note that to access the global site. variables, I had to change the render calls for these partials to include.

@antfitch
Copy link
Collaborator Author

Looks good to me! Thanks for consolidating these.

Note that to access the global site. variables, I had to change the render calls for these partials to include.

Thank you so much for doing this!

@antfitch antfitch merged commit 5fbf70a into main Jun 10, 2025
11 checks passed
@antfitch antfitch self-assigned this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants