Skip to content

js_interop_gen: support the latest pkg:analyzer #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevmoo merged 13 commits into from
Jun 13, 2026
Merged

js_interop_gen: support the latest pkg:analyzer #547

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6d70cbb
js_interop_gen: support the latest pkg:analyzer
kevmoo May 9, 2026
3659e13
Checking formatting on 3.10 - see TODO
kevmoo May 13, 2026
da279c3
Merge remote-tracking branch 'origin/HEAD' into latest_analyzer
kevmoo May 27, 2026
fe77505
fix formatting
kevmoo May 27, 2026
b22f682
Merge remote-tracking branch 'origin/HEAD' into latest_analyzer
kevmoo Jun 12, 2026
e4401f1
Format generated integration test outputs with SDK formatter
kevmoo Jun 12, 2026
74197cc
Run formatting check on dev SDK instead of 3.10
kevmoo Jun 12, 2026
1fa1e2c
Bump minimum SDK to 3.12, remove CI format checks, and update expecte…
kevmoo Jun 12, 2026
5478a12
Fix static analysis warnings using initializing formals for private f…
kevmoo Jun 12, 2026
88cc219
Fix static analysis warnings, bump SDK constraints, and add unnecessa…
kevmoo Jun 12, 2026
f5b5037
Restore generator formatting to golden files to resolve formatting co…
kevmoo Jun 13, 2026
680632a
not a breaking change for an unreleased package
kevmoo Jun 13, 2026
d5a9324
changelog tweak
kevmoo Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/js_interop_gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ jobs:
run: touch .last_npm_install
working-directory: js_interop_gen/lib/src
- run: dart format --output=none --set-exit-if-changed .
if: matrix.sdk == 'dev' && matrix.test_config == ''
# NOTE: validating formatting on 3.10 (NOT dev)
# because pkg:dart_style does not support formatting code
# that aligns with changes in the latest Dart dev SDK
if: matrix.sdk == '3.10' && matrix.test_config == ''
- run: dart analyze --fatal-infos
if: matrix.sdk == 'dev' && matrix.test_config == ''
- run: dart analyze
Expand Down
2 changes: 1 addition & 1 deletion js_interop_gen/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ environment:
sdk: ^3.10.0

dependencies:
analyzer: ^12.0.0
analyzer: '>=12.0.0 <14.0.0'
args: ^2.5.0
code_builder: ^4.10.0
collection: ^1.19.1
Expand Down
3 changes: 2 additions & 1 deletion js_interop_gen/test/integration/interop_gen/_tuples.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import 'dart:js_interop' as _i1;

extension type JSTuple2<A extends _i1.JSAny?, B extends _i1.JSAny?>._(
_i1.JSArray<_i1.JSAny?> _
) implements _i1.JSArray<_i1.JSAny?> {
)
implements _i1.JSArray<_i1.JSAny?> {
A get $1 => (_[0] as A);

B get $2 => (_[1] as B);
Expand Down
3 changes: 2 additions & 1 deletion js_interop_gen/test/integration/interop_gen/namespaces_expected.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,8 @@ extension type EnterpriseApp_DataServices._(_i1.JSObject _)
@_i1.JS('EnterpriseApp.DataServices.IDataService')
extension type EnterpriseApp_DataServices_IDataService<T extends _i1.JSAny?>._(
_i1.JSObject _
) implements _i1.JSObject {
)
implements _i1.JSObject {
external _i1.JSArray<T> getAll();
external T getById(String id);
external void save(T item);
Expand Down
3 changes: 2 additions & 1 deletion js_interop_gen/test/integration/interop_gen/ts_typing_expected.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ extension type const KeyOf_TypeOf_MyEnum._(String _) {
}
extension type _AnonymousFunction_3217419<T extends _i1.JSAny?>._(
_i1.JSFunction _
) implements _i1.JSFunction {
)
implements _i1.JSFunction {
external ComposedType<T> call(T object);
}
extension type ComposedType<T extends _i1.JSAny?>._(_i1.JSObject _)
Expand Down
Loading