Skip to content

Fix venv path extraction for Poetry >v0.12.17 - #6

Open
weilbith wants to merge 1 commit into
darvid:masterfrom
weilbith:bugfix/support_poetry_v0.12.17
Open

Fix venv path extraction for Poetry >v0.12.17#6
weilbith wants to merge 1 commit into
darvid:masterfrom
weilbith:bugfix/support_poetry_v0.12.17

Conversation

@weilbith

@weilbith weilbith commented Apr 2, 2020

Copy link
Copy Markdown

I recognized that this plugin was not working anymore. I turned out that is was caused due to an update of Poetry. This PR fixes this issue. Unhappily it is not backward compatible with older versions. Such would require much more overhead. But Poetry is not yet stable in general. So future interface changes are expected.

The command interface of Poetry has changed. The obsolete command
`debug` has been split into `debug:info` and `debug:resolve`.
Furthermore has the output changed slightly, so it was necessary to
adjust the path extraction pattern.
@weilbith

Copy link
Copy Markdown
Author

I just realized that it has changed again for the latest version. 馃檲
Se we should consider to export that into its own function which switch the
command for the respective version. What do you think @darvid

@NeilGirdhar

NeilGirdhar commented Jul 17, 2021

Copy link
Copy Markdown
Collaborator

This pull request doesn't work anymore. I submitted #8 for Poetry >= 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants