Conversation
There was a problem hiding this comment.
Pull Request Overview
Deprecate use of sp-std by removing it from dependencies and replacing its APIs with core/alloc imports across various crates.
- Remove
sp-stdentries inCargo.tomlandstdfeature lists. - Add
extern crate allocwhere needed and replacesp_stdimports withcoreoralloc. - Update
no_stdmodules to depend onallocandcorecrates appropriately.
Reviewed Changes
Copilot reviewed 85 out of 85 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| precompile/state-storage/src/lib.rs | Add alloc for tests and switch comment to // core |
| precompile/state-storage/Cargo.toml | Remove sp-std dependency |
| precompile/assets/src/tests.rs | Replace sp_std::str::from_utf8 with alloc::str |
| precompile/assets/src/mock.rs | Replace sp_std::prelude::* with alloc::vec::Vec |
| precompile/assets/src/lib.rs | Add alloc for tests; import core conversions |
| precompile/assets/Cargo.toml | Remove sp-std entries |
| pallet/staking/src/lib.rs | Add alloc imports; remove sp_std use |
| pallet/staking/src/benchmarking.rs | Remove sp_std::prelude::* |
| pallet/staking/Cargo.toml | Remove sp-std entries |
| pallet/ethtx-forwarder/src/mock.rs | Remove sp_std::prelude::* |
| pallet/ethtx-forwarder/src/lib.rs | Add alloc imports; remove sp_std::vec::Vec |
| pallet/ethtx-forwarder/Cargo.toml | Remove sp-std entries |
| pallet/deposit/src/lib.rs | Add alloc imports; remove sp_std::prelude::* |
| pallet/deposit/src/benchmarking.rs | Remove sp_std::prelude::* |
| pallet/deposit/Cargo.toml | Remove sp-std entries |
| pallet/account-migration/src/lib.rs | Add alloc imports; remove sp_std::prelude::* |
| pallet/account-migration/src/benchmarking.rs | Remove sp_std::prelude::* |
| pallet/account-migration/Cargo.toml | Remove sp-std entries |
| Cargo.toml | Remove top-level sp-std dependency |
| .maintain/pallet-weight-template.hbs | Replace sp_std::marker::PhantomData with core import |
boundless-forest
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.