Skip to content

Fix action_hook for vagrant 2.2.14 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aki2o
Copy link

@aki2o aki2o commented Feb 22, 2021

This fix is for #8
This trouble looks to be caused by changing timing to call vagrant action hooks after vagrant 2.2.14
I tried to fix config for action_hook with the following way.

  • Avoid append hook
  • Select a hooked action which looks good timing in builtin actions for before after hook
  • Reverse after hook definition order because after hook looks to be called order by desc

And, the following some misc fixes be included

  • Call RemoveConfig with keeping in step with other actions
  • Fix console output
  • Quit RemoveConfig on suspend and halt because I feel we still need ssh config on their timings

This fix works in my environment but I'm hesitating by the following reasons.

@dasginganinja
Copy link
Owner

This applies after #8 ? I just merged that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants