Skip to content

chore(collectors): add dash0.metric.datapoint.interval scope attribute #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
basti1302 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Draft

chore(collectors): add dash0.metric.datapoint.interval scope attribute #1117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/collectors/otelcolresources/daemonset.config.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,11 @@ receivers:
honor_labels: true
fallback_scrape_protocol: "PrometheusText0.0.4"

# scrape_interval and scrape_timeout are the Prometheus defaults (stated here to make the configuration explicit
# and transparent)
scrape_interval: 1m
scrape_timeout: 10s

kubernetes_sd_configs:
- role: pod
# only scrape data from pods running on the same node as collector
Expand Down Expand Up @@ -778,6 +783,14 @@ processors:
transform/metrics/prometheus_service_attributes:
error_mode: ignore
metric_statements:
# Note: This group needs to run before the datapoint group below, which rewrites or removes service.name (which
# at this point still carries the scrape job name). The attribute values need to match the scrape_interval of the
# respective scrape job. It improves the resolution of $__rate_interval for rate/irate queries Prometheus
# annotation-based scraped metrics for shorter time frames.
- context: scope
statements:
- set(scope.attributes["dash0.metric.datapoint.interval"], "1m") where resource.attributes["service.name"] == "dash0-kubernetes-pods-scrape-config"
- set(scope.attributes["dash0.metric.datapoint.interval"], "5m") where resource.attributes["service.name"] == "dash0-kubernetes-pods-scrape-config-slow"
- context: datapoint
statements:

Expand Down
Loading