-
Notifications
You must be signed in to change notification settings - Fork 15
Add LazyHTML.Tree.postreduce/3 and LazyHTML.Tree.prereduce/3 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
89f0a33
Add LazyHTML.Tree.traverse/3
ypconstante 8e33368
Rename to postreduce
ypconstante 3c2d3b6
Update lib/lazy_html/tree.ex
ypconstante 149a080
Add LazyHTML.Tree.prereduce/3
ypconstante 0bdfe69
Update test/lazy_html/tree_test.exs
jonatanklosko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -172,6 +172,36 @@ defmodule LazyHTML.Tree do | |
| @doc """ | ||
| Performs a depth-first, post-order traversal of the given tree. | ||
|
|
||
| This function traverses the tree without modifying it, check `postwalk/2` and | ||
| `postwalk/3` if you need to modify the tree. | ||
| """ | ||
| @spec traverse( | ||
| t(), | ||
| acc, | ||
| (html_node(), acc -> acc) | ||
| ) :: acc | ||
| when acc: term() | ||
| def traverse(tree, acc, fun), do: do_traverse(tree, acc, fun) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need for the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| defp do_traverse([], acc, _fun), do: acc | ||
|
|
||
| defp do_traverse([node | rest], acc, fun) do | ||
| acc = do_traverse(node, acc, fun) | ||
| do_traverse(rest, acc, fun) | ||
| end | ||
|
|
||
| defp do_traverse({tag, attrs, children}, acc, fun) do | ||
| acc = do_traverse(children, acc, fun) | ||
| fun.({tag, attrs, children}, acc) | ||
| end | ||
|
|
||
| defp do_traverse(node, acc, fun) do | ||
| fun.(node, acc) | ||
| end | ||
|
|
||
| @doc """ | ||
| Performs a depth-first, post-order traversal of the given tree. | ||
|
|
||
| The mapper `fun` can return a list of nodes to replace the given | ||
| node. In order to remove a node, return an empty list. | ||
| """ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Elixir, Macro.traverse is both prewalk and postwalk combined. So I think we should pick a different name here... maybe
postwalk_reduce?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postvisit,postscan, since they better indicate read-only?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postscanis also fine by me. Orpostreduce.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like
postreduce!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8e33368
renamed to
postreduce