Add test coverage for ascii_string/utf8_string min/max - #153
Merged
Conversation
Two gaps in the current suite:
* `generate/1` had no coverage for `ascii_string`/`utf8_string` at all,
so nothing exercised the combinators these expand to.
* every `utf8_string` test uses an empty range. An empty range may match
a newline, which is the condition that decides whether the combinator
needs per-codepoint line tracking, so the newline-free case was never
covered. The added tests pin both it and a `[not: ?\n]` class that must
stop the scan at the newline.
These characterise existing behaviour and pass unchanged against the
current implementation.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at the code I found two gaps in the current test suite:
generate/1had no coverage forascii_string/utf8_stringat all, so nothing exercised the combinators these expand to.utf8_stringtest used an empty range.These characterise existing behaviour and pass unchanged against the current implementation.