fix: Allow choice fallback after traversal errors - #154
Merged
josevalim merged 1 commit intoAug 11, 2026
Conversation
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update traversal error generation in
NimbleParsec.Compilerto honor the activecatch_allcontinuation already carried in compiler configuration, following the failure-routing pattern used by other unbound combinators.post_traverse/3callbacks may return{:error, reason}, but the compiler currently turns that result directly into the parsec's final error tuple.A
choice/2whose first branch consumes input and then succeeds in a post-traversal callback returns that branch's transformed result without evaluating the fallback behavior; A post-traversal callback that returns{:error, reason}causeschoice/2to retry a later branch from the original input, producing the fallback result with correct rest, context, position, and byte offset.Closes #146