Skip to content

CI and docs housekeeping - #40

Merged
josevalim merged 1 commit into
dashbitco:masterfrom
myfloss:ci-and-doc-housekeeping
Nov 23, 2025
Merged

CI and docs housekeeping#40
josevalim merged 1 commit into
dashbitco:masterfrom
myfloss:ci-and-doc-housekeeping

Conversation

@kianmeng

@kianmeng kianmeng commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

List of changes:

  • add changelog link to hex module view
  • bump actions/checkout and actions/cache
  • bump ex_doc and related deps
  • improve test coverage
  • remove deprecated code since we're on OTP 24
  • set minimal Elixir requirement to 1.13
  • support Elixir 1.19/OTP 28 in CI matrix

Comment thread .github/workflows/main.yml Outdated
Comment on lines +19 to +21
elixir: "1.12"
otp: "22"
runner: "ubuntu-20.04"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josevalim Do we still want to support Elixir 1.12, judging that setup-beam have minimal support for Erlang OTP 24.2 for its Ubuntu image, see https://github.com/erlef/setup-beam?tab=readme-ov-file#compatibility-between-operating-system-and-erlangotp?

Should we move to Elixir 1.15? If not, Elixir 1.13 is the minimal supported version that works on Erlang OTP 24, see https://hexdocs.pm/elixir/compatibility-and-deprecations.html#between-elixir-and-erlang-otp, which is supported by setup-beam ubuntu-22.04 image.

Comment thread lib/nimble_totp.ex
else
defp hmac_sha(key, data), do: :crypto.hmac(:sha, key, data)
end
defp hmac_sha(key, data), do: :crypto.mac(:hmac, :sha, key, data)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're on Elixir 1.12, which supported by Erlang OTP 22-24?

@josevalim

josevalim commented Nov 23, 2025 via email

Copy link
Copy Markdown
Member

@kianmeng
kianmeng force-pushed the ci-and-doc-housekeeping branch from 151a090 to c3141d9 Compare November 23, 2025 14:42
List of changes:
- add changelog link to hex module view
- bump actions/checkout and actions/cache
- bump ex_doc and related deps
- improve test coverage
- remove deprecated code since we're on OTP 24
- set minimal Elixir requirement to 1.13
- support Elixir 1.19/OTP 28 in CI matrix
@kianmeng
kianmeng force-pushed the ci-and-doc-housekeeping branch from c3141d9 to 17ff4a0 Compare November 23, 2025 14:45
@kianmeng

Copy link
Copy Markdown
Contributor Author

Let’s do the minimal version we can, which would be 1.13 but it is no problem if it is 1.14 or 1.15!

@josevalim Done. Set the minimal Elixir requirement to 1.13.

@josevalim
josevalim merged commit 5083304 into dashbitco:master Nov 23, 2025
2 checks passed
@kianmeng

Copy link
Copy Markdown
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants