Skip to content
This repository was archived by the owner on Mar 28, 2022. It is now read-only.

Conversation

@glenkleidon
Copy link

@glenkleidon glenkleidon commented Jan 21, 2021

This is the fix for Issue 7. #7

Tested on chrome

@braveheart84
Copy link

Can we have this PR merged please?

@andreasanta
Copy link

@phillytan @m-banik Can you please merge this? It's a blocker for our security team. Thank you!

@m-banik
Copy link
Contributor

m-banik commented Dec 15, 2021

@andreasanta, I will, but I cannot guarantee that it won't cause any of the new issues.

@andreasanta
Copy link

@m-banik Thank you! What new issues are you referring to?

@m-banik
Copy link
Contributor

m-banik commented Dec 15, 2021

Oh, I apologize. It was kind of surprise for me that I was mentioned here and I didn't recall some of the obvious facts. I have no write access and thus I cannot merge this PR.

@m-banik
Copy link
Contributor

m-banik commented Dec 15, 2021

@andreasanta, I know the changes are few, but I don't know the entire code base. I couldn't be sure that they won't affect anything else in a way that you would not want it to. Also, in relation to the above, I made but one PR to this repo some time ago and then forgot about it. Sorry I can't be more helpful.

@m-banik
Copy link
Contributor

m-banik commented Dec 15, 2021

@andreasanta, I see that @phillytan is indeed the correct addressee of your request.

@andreasanta
Copy link

@m-banik No worries, thanks very much for your help anyways!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants