Skip to content

chore: rename fields for elastic #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v1.0-dev
Choose a base branch
from
Open

Conversation

ktechmidas
Copy link
Contributor

@ktechmidas ktechmidas commented Sep 11, 2023

Issue being fixed or feature implemented

Issue of consistency with tenderdash fixed

What was done?

Renamed json.span.height to json.height and json.span.round to json.round in elastic for consistency with Tenderdash

How Has This Been Tested?

N/T

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy
Copy link
Collaborator

strophy commented Sep 12, 2023

@ktechmidas please test this and verify logs are received in a useful format

@@ -43,3 +43,11 @@ filebeat_platform_inputs:
fields:
- from: "json.level"
- to: "log.level"
- rename:
fields:
- from: "json.span.height"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct path will be json.spans.height. Why do you want to rename it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to rename it to have the same name as in tenderdash, to make filter/search easier

- rename:
fields:
- from: "json.span.height"
- to: "json.height"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it must be:

- from:
   to:

@shumkov shumkov changed the base branch from v0.25-dev to v1.0-dev January 13, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants