-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Replace prometheus with metricbeat by extending the elastic_stack role #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1.0-dev
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,18 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have already metric beats in #617. How do you replace Prometheus here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prometheus is used for data collection in the Tenderdash nodes as indicated by the configuration in the ansible/roles/metrics/templates/prometheus.yml.j2 file
To replace Prometheus with Metricbeat for collecting data from the Prometheus exporters, the Metricbeat role has been introduced with a configuration to scrape metrics from Prometheus endpoints. (ansible/roles/metricbeat/templates/metricbeat.yml.j2)
This new metricbeat role will be applied on the same logs instances where elastic_stack is being applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have metric beats on the nodes where we are running tenderdash. Why not just configure them to collect data from tenderdash and send to elastic?
bf5651e
to
3574d36
Compare
@@ -22,3 +22,10 @@ platform_filebeat_inputs: | |||
fields: | |||
- from: "json.level" | |||
to: "log.level" | |||
|
|||
metricbeat_modules: | |||
- module: prometheus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be defined in configuration
|
||
- name: Upload and apply Tenderdash log parsing pipeline | ||
ansible.builtin.uri: | ||
url: "{{ elasticsearch_url }}/logstash/_pipeline/process_proposal_pipeline" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be defined
metricbeat_modules: | ||
- module: prometheus | ||
period: 10s | ||
hosts: ["localhost:{{ prometheus_port }}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private_ip
Issue being fixed or feature implemented
The metricbeat role has been added to replace Prometheus for data collection.
What was done?
The existing elastic_stack role has been extended by a new role named metricbeat to replace Prometheus by metricbeat for data collection
How Has This Been Tested?
Breaking Changes
This is an addition
Checklist: