Skip to content

feat: Replace prometheus with metricbeat by extending the elastic_stack role #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: v1.0-dev
Choose a base branch
from

Conversation

vivekgsharma
Copy link
Collaborator

Issue being fixed or feature implemented

The metricbeat role has been added to replace Prometheus for data collection.

What was done?

The existing elastic_stack role has been extended by a new role named metricbeat to replace Prometheus by metricbeat for data collection

How Has This Been Tested?

Breaking Changes

This is an addition

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@@ -0,0 +1,18 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have already metric beats in #617. How do you replace Prometheus here?

Copy link
Collaborator Author

@vivekgsharma vivekgsharma Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prometheus is used for data collection in the Tenderdash nodes as indicated by the configuration in the ansible/roles/metrics/templates/prometheus.yml.j2 file

To replace Prometheus with Metricbeat for collecting data from the Prometheus exporters, the Metricbeat role has been introduced with a configuration to scrape metrics from Prometheus endpoints. (ansible/roles/metricbeat/templates/metricbeat.yml.j2)

This new metricbeat role will be applied on the same logs instances where elastic_stack is being applied.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have metric beats on the nodes where we are running tenderdash. Why not just configure them to collect data from tenderdash and send to elastic?

Base automatically changed from metricbeats to v1.0-dev March 21, 2024 15:22
@vivekgsharma vivekgsharma force-pushed the Prometheus_metricbeats branch from bf5651e to 3574d36 Compare March 22, 2024 17:21
@@ -22,3 +22,10 @@ platform_filebeat_inputs:
fields:
- from: "json.level"
to: "log.level"

metricbeat_modules:
- module: prometheus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be defined in configuration


- name: Upload and apply Tenderdash log parsing pipeline
ansible.builtin.uri:
url: "{{ elasticsearch_url }}/logstash/_pipeline/process_proposal_pipeline"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be defined

metricbeat_modules:
- module: prometheus
period: 10s
hosts: ["localhost:{{ prometheus_port }}"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private_ip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants