Prepare 11.4.1 #1432
Prepare 11.4.1 #1432
Conversation
WalkthroughRelease dependency versions were updated. A new hint string was added across common module locales. ExploreDash gained a new localized session-expired title. Wallet module removed the same hint string across locales and adjusted various UI texts and one menu key. Checkpoints value was updated. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
♻️ Duplicate comments (5)
features/exploredash/src/main/res/values-ko/strings-explore-dash.xml (1)
244-245: LGTMString key and placement look good. Global verification requested in a previous comment.
features/exploredash/src/main/res/values-el/strings-explore-dash.xml (1)
248-249: LGTMCorrect key and natural phrasing.
features/exploredash/src/main/res/values-es/strings-explore-dash.xml (1)
252-253: LGTMNatural phrasing and correct placement.
features/exploredash/src/main/res/values-uk/strings-explore-dash.xml (1)
256-257: LGTMKey addition is correct and consistent with other locales.
features/exploredash/src/main/res/values-pl/strings-explore-dash.xml (1)
256-257: LGTMString and placement look good.
🧹 Nitpick comments (20)
wallet/res/values-es/strings-extra.xml (1)
279-280: Spanish phrasing polish
- Optional: change
- <string name="menu_rescan_blockchain">Escanear de nuevo la cadena de bloques</string> + <string name="menu_rescan_blockchain">Volver a escanear la cadena de bloques</string>build.gradle (1)
6-7: Release versions set correctly; consider pruning snapshot repos for release builds.Keeping snapshot repositories can cause accidental snapshot resolutions. For a release prep branch, consider disabling snapshot repos or scoping them only where needed.
common/src/main/res/values-ja/strings.xml (1)
99-99: Japanese string reads well.Optional: add a trailing “。” for consistency.
common/src/main/res/values-zh/strings.xml (1)
99-99: Optional CN punctuation polish
Use full-width punctuation for consistency: “因钱包与网络还未完成同步，当前无法支付。”common/src/main/res/values-es/strings.xml (1)
99-99: Improve Spanish phrasing and punctuationMore natural and consistent:
- <string name="send_coins_fragment_hint_replaying">Actualmente, pagos no son posibles porque la billetera no está completamente sincronizada con la red</string> + <string name="send_coins_fragment_hint_replaying">Actualmente no es posible realizar pagos porque la billetera no está completamente sincronizada con la red.</string>common/src/main/res/values-th/strings.xml (1)
95-95: Refine Thai grammar for claritySuggested wording:
- <string name="send_coins_fragment_hint_replaying">ขณะนี้ยังไม่สามารถทำการชำระเงินได้เนื่องกระเป๋าสตางค์ยังไม่เชื่อมต่อกับเครือข่าย</string> + <string name="send_coins_fragment_hint_replaying">ขณะนี้ไม่สามารถชำระเงินได้ เนื่องจากกระเป๋าสตางค์ยังไม่ได้ซิงค์กับเครือข่ายอย่างสมบูรณ์</string>common/src/main/res/values-tr/strings.xml (1)
95-95: Fix Turkish typo and styleUse “şu an” and smoother phrasing:
- <string name="send_coins_fragment_hint_replaying">Cüzdanınız ağ ile senkronize olmadığından şuan ödeme yapabilmeniz mümkün değil.</string> + <string name="send_coins_fragment_hint_replaying">Cüzdanınız ağ ile senkronize olmadığından şu an ödeme yapmanız mümkün değil.</string>common/src/main/res/values-ko/strings.xml (1)
99-99: Fix Korean spacing and terminologyUse “결제할 수 없습니다.” and add period:
- <string name="send_coins_fragment_hint_replaying">지갑이 네트워크와 완전히 동기화되지 않아 현재 지불 할 수 없습니다</string> + <string name="send_coins_fragment_hint_replaying">지갑이 네트워크와 완전히 동기화되지 않아 현재 결제할 수 없습니다.</string>common/src/main/res/values-id/strings.xml (1)
99-99: Polish Indonesian phrasing and punctuationSuggestion:
- <string name="send_coins_fragment_hint_replaying">Saat ini pembayaran tidak dimungkinkan karena dompet tidak sepenuhnya disinkronkan dengan jaringan</string> + <string name="send_coins_fragment_hint_replaying">Saat ini pembayaran tidak dapat dilakukan karena dompet belum sepenuhnya tersinkron dengan jaringan.</string>common/src/main/res/values-uk/strings.xml (1)
99-99: Optional: add terminal period for consistency with surrounding sentences- <string name="send_coins_fragment_hint_replaying">Наразі платежі неможливі, оскільки гаманець не повністю синхронізовано з мережею</string> + <string name="send_coins_fragment_hint_replaying">Наразі платежі неможливі, оскільки гаманець не повністю синхронізовано з мережею.</string>common/src/main/res/values-zh-rTW/strings.xml (1)
99-99: Taiwan locale: prefer 網路 and slightly more idiomatic phrasing- <string name="send_coins_fragment_hint_replaying">目前無法付款，因為錢包未與網絡完全同步</string> + <string name="send_coins_fragment_hint_replaying">目前無法付款，因為錢包尚未與網路完全同步</string>common/src/main/res/values-pt/strings.xml (1)
99-99: Optional: more natural PT phrasing- <string name="send_coins_fragment_hint_replaying">Pagamentos não são possíveis no momento porque a carteira não está totalmente sincronizada com a rede</string> + <string name="send_coins_fragment_hint_replaying">No momento, os pagamentos não são possíveis porque a carteira não está totalmente sincronizada com a rede.</string>common/src/main/res/values-nl/strings.xml (1)
99-99: Optional: add “nog” and a period for clarity- <string name="send_coins_fragment_hint_replaying">Momenteel zijn betalingen niet mogelijk omdat de portemonnee niet volledig is gesynchroniseerd met het netwerk</string> + <string name="send_coins_fragment_hint_replaying">Momenteel zijn betalingen niet mogelijk omdat de portemonnee nog niet volledig met het netwerk is gesynchroniseerd.</string>wallet/res/values-ru/strings-extra.xml (1)
283-283: RU menu label update: LGTM.Optional: ensure “цепочка блоков” vs “блокчейн” wording is consistent across the RU UI (e.g., syncing labels).
common/src/main/res/values-el/strings.xml (1)
99-99: Optional: add terminal punctuation for consistency.Add a period at the end to match other locales.
- <string name="send_coins_fragment_hint_replaying">Αυτή την στιγμή δεν διεκπεραιώνονται πληρωμές γιατί το πορτοφόλι δεν έχει συγχρονιστεί πλήρως με το δίκτυο</string> + <string name="send_coins_fragment_hint_replaying">Αυτή την στιγμή δεν διεκπεραιώνονται πληρωμές γιατί το πορτοφόλι δεν έχει συγχρονιστεί πλήρως με το δίκτυο.</string>common/src/main/res/values-fa/strings.xml (1)
99-99: Optional: add full stop at sentence end.Keeps style consistent with other locales.
- <string name="send_coins_fragment_hint_replaying">پرداختهای کنونی امکانپذیر نیست، زیرا کیف پول به خوبی با شبکه همزمان نشده است</string> + <string name="send_coins_fragment_hint_replaying">پرداختهای کنونی امکانپذیر نیست، زیرا کیف پول به خوبی با شبکه همزمان نشده است.</string>common/src/main/res/values-it/strings.xml (1)
100-100: Optional: add terminal period.Align punctuation with other locales.
- <string name="send_coins_fragment_hint_replaying">Attualmente i pagamenti non sono possibili perché il portafoglio non è completamente sincronizzato con la rete</string> + <string name="send_coins_fragment_hint_replaying">Attualmente i pagamenti non sono possibili perché il portafoglio non è completamente sincronizzato con la rete.</string>common/src/main/res/values-fr/strings.xml (1)
99-99: Optional: add terminal period.For consistency with other locales.
- <string name="send_coins_fragment_hint_replaying">Les paiements ne sont pas encore possibles car le portefeuille n'est pas entièrement synchronisé avec le réseau</string> + <string name="send_coins_fragment_hint_replaying">Les paiements ne sont pas encore possibles car le portefeuille n'est pas entièrement synchronisé avec le réseau.</string>features/exploredash/src/main/res/values-fa/strings-explore-dash.xml (1)
248-248: No behavioral change; OK. Also consider adding the new key for FA.Only indentation changed. For UX consistency, add token_expired_title in FA as well when available.
features/exploredash/src/main/res/values-ja/strings-explore-dash.xml (1)
244-245: Japanese: prefer 有効期限 over 有効時間More natural phrasing for “session expired”.
- <string name="token_expired_title">セッションの有効時間が切れました</string> + <string name="token_expired_title">セッションの有効期限が切れました</string>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (79)
build.gradle(1 hunks)common/src/main/res/values-ar/strings.xml(1 hunks)common/src/main/res/values-cs/strings.xml(1 hunks)common/src/main/res/values-de/strings.xml(1 hunks)common/src/main/res/values-el/strings.xml(1 hunks)common/src/main/res/values-es/strings.xml(1 hunks)common/src/main/res/values-fa/strings.xml(1 hunks)common/src/main/res/values-fil/strings.xml(1 hunks)common/src/main/res/values-fr/strings.xml(1 hunks)common/src/main/res/values-id/strings.xml(1 hunks)common/src/main/res/values-it/strings.xml(1 hunks)common/src/main/res/values-ja/strings.xml(1 hunks)common/src/main/res/values-ko/strings.xml(1 hunks)common/src/main/res/values-nl/strings.xml(1 hunks)common/src/main/res/values-pl/strings.xml(1 hunks)common/src/main/res/values-pt/strings.xml(1 hunks)common/src/main/res/values-ru/strings.xml(1 hunks)common/src/main/res/values-sk/strings.xml(1 hunks)common/src/main/res/values-th/strings.xml(1 hunks)common/src/main/res/values-tr/strings.xml(1 hunks)common/src/main/res/values-uk/strings.xml(1 hunks)common/src/main/res/values-zh-rTW/strings.xml(1 hunks)common/src/main/res/values-zh/strings.xml(1 hunks)features/exploredash/src/main/res/values-de/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-el/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-es/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-fa/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-fil/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-fr/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-id/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-it/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-ja/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-ko/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-nl/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-pl/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-pt/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-ru/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-sk/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-uk/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-zh-rTW/strings-explore-dash.xml(1 hunks)features/exploredash/src/main/res/values-zh/strings-explore-dash.xml(1 hunks)wallet/assets/checkpoints.txt(2 hunks)wallet/res/values-ar/strings-extra.xml(1 hunks)wallet/res/values-ar/strings.xml(0 hunks)wallet/res/values-bg/strings.xml(0 hunks)wallet/res/values-cs/strings-extra.xml(1 hunks)wallet/res/values-cs/strings.xml(0 hunks)wallet/res/values-de/strings.xml(0 hunks)wallet/res/values-el/strings.xml(0 hunks)wallet/res/values-es/strings-extra.xml(1 hunks)wallet/res/values-es/strings.xml(0 hunks)wallet/res/values-fa/strings-extra.xml(0 hunks)wallet/res/values-fa/strings.xml(0 hunks)wallet/res/values-fil/strings-extra.xml(1 hunks)wallet/res/values-fil/strings.xml(0 hunks)wallet/res/values-fr/strings.xml(0 hunks)wallet/res/values-id/strings-extra.xml(1 hunks)wallet/res/values-id/strings.xml(0 hunks)wallet/res/values-it/strings.xml(0 hunks)wallet/res/values-ja/strings.xml(0 hunks)wallet/res/values-ko/strings.xml(0 hunks)wallet/res/values-nl/strings-extra.xml(1 hunks)wallet/res/values-nl/strings.xml(0 hunks)wallet/res/values-pl/strings-extra.xml(1 hunks)wallet/res/values-pl/strings.xml(0 hunks)wallet/res/values-pt/strings-extra.xml(1 hunks)wallet/res/values-pt/strings.xml(0 hunks)wallet/res/values-ru/strings-dashpay.xml(0 hunks)wallet/res/values-ru/strings-extra.xml(1 hunks)wallet/res/values-ru/strings.xml(0 hunks)wallet/res/values-sk/strings-dashpay.xml(2 hunks)wallet/res/values-sk/strings.xml(0 hunks)wallet/res/values-th/strings.xml(0 hunks)wallet/res/values-tr/strings-extra.xml(1 hunks)wallet/res/values-tr/strings.xml(0 hunks)wallet/res/values-uk/strings.xml(0 hunks)wallet/res/values-vi/strings.xml(0 hunks)wallet/res/values-zh-rTW/strings.xml(0 hunks)wallet/res/values-zh/strings.xml(0 hunks)
💤 Files with no reviewable changes (26)
- wallet/res/values-zh/strings.xml
- wallet/res/values-ru/strings-dashpay.xml
- wallet/res/values-fr/strings.xml
- wallet/res/values-ja/strings.xml
- wallet/res/values-uk/strings.xml
- wallet/res/values-es/strings.xml
- wallet/res/values-ar/strings.xml
- wallet/res/values-sk/strings.xml
- wallet/res/values-fa/strings-extra.xml
- wallet/res/values-nl/strings.xml
- wallet/res/values-id/strings.xml
- wallet/res/values-el/strings.xml
- wallet/res/values-cs/strings.xml
- wallet/res/values-ko/strings.xml
- wallet/res/values-it/strings.xml
- wallet/res/values-ru/strings.xml
- wallet/res/values-pl/strings.xml
- wallet/res/values-bg/strings.xml
- wallet/res/values-pt/strings.xml
- wallet/res/values-tr/strings.xml
- wallet/res/values-zh-rTW/strings.xml
- wallet/res/values-fil/strings.xml
- wallet/res/values-th/strings.xml
- wallet/res/values-de/strings.xml
- wallet/res/values-vi/strings.xml
- wallet/res/values-fa/strings.xml
👮 Files not reviewed due to content moderation or server errors (1)
- wallet/assets/checkpoints.txt
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: HashEngineering
PR: dashpay/dash-wallet#1422
File: common/src/main/java/org/dash/wallet/common/util/Constants.kt:68-69
Timestamp: 2025-08-25T15:00:20.777Z
Learning: HashEngineering prefers to keep HTTP logging enabled in release mode (using log.info instead of gating with BuildConfig.DEBUG) to debug production errors, even though this may leak URLs in production logs. This is a deliberate trade-off for debugging purposes in the Dash wallet project.
Learnt from: HashEngineering
PR: dashpay/dash-wallet#1410
File: wallet/src/de/schildbach/wallet/data/InvitationLinkData.kt:79-84
Timestamp: 2025-07-12T07:12:04.769Z
Learning: HashEngineering prefers to handle defensive validation improvements for URI parsing in follow-up PRs rather than including them in the current PR when the main focus is on replacing Firebase with AppsFlyer.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: check
🔇 Additional comments (20)
wallet/res/values-ar/strings-extra.xml (1)
272-272: LGTM — consistent Arabic phrasing for “Rescan Blockchain”.Matches existing usage at Line 252 and maintains terminology consistency.
wallet/res/values-sk/strings-dashpay.xml (1)
456-456: LGTM: style aligns with list contextInfinitive form fits “Vaše kredity môžete použiť na:” bullet style.
wallet/res/values-pt/strings-extra.xml (1)
279-279: menu_local_currency key usage and locale coverage confirmed
Definitions in strings-extra.xml cover all wallet layouts referencing this key; no missing translations.wallet/res/values-tr/strings-extra.xml (1)
267-268: Turkish capitalization updates look good.Sentence case aligns with other locales.
common/src/main/res/values-ar/strings.xml (1)
94-94: LGTM – clear Arabic phrasing.No issues spotted.
wallet/res/values-id/strings-extra.xml (1)
274-274: Indonesian label update looks good.Matches sentence‑case style.
wallet/res/values-nl/strings-extra.xml (1)
276-276: Dutch capitalization change approved.Consistent with sentence case.
wallet/res/values-cs/strings-extra.xml (1)
250-251: Casing fixes look goodMatches sentence case used in nearby menu labels.
common/src/main/res/values-de/strings.xml (1)
99-99: LGTMWording is clear and idiomatic.
common/src/main/res/values-cs/strings.xml (1)
69-69: LGTM
Confirmedsend_coins_fragment_hint_replayingis defined only incommon/src/main/res/values-*/strings.xmlacross locales; no wallet-module definitions shadow this key.wallet/res/values-pl/strings-extra.xml (1)
282-283: LGTM on capitalization fixesThe updated casing for “Lokalna waluta” and “blockchain” is correct and consistent.
common/src/main/res/values-pl/strings.xml (1)
99-99: No duplicate string key in wallet module
Confirmedsend_coins_fragment_hint_replayingexists only in common resources and is absent from the wallet module.common/src/main/res/values-ru/strings.xml (1)
99-99: Confirmed relocation of replaying hint: no duplicates remain
No occurrences ofsend_coins_fragment_hint_replayingunderwallet/**; it’s defined only incommon/src/main/res/values*for all locales.features/exploredash/src/main/res/values-fr/strings-explore-dash.xml (1)
252-253: LGTM – new session-expired title added.Translation and placement look good.
features/exploredash/src/main/res/values-fil/strings-explore-dash.xml (1)
248-249: LGTM – Filipino session-expired title added.Consistent with other locales.
features/exploredash/src/main/res/values-nl/strings-explore-dash.xml (1)
248-249: LGTM – Dutch session-expired title added.Looks correct.
features/exploredash/src/main/res/values-zh-rTW/strings-explore-dash.xml (1)
244-245: LGTM – Traditional Chinese session-expired title added.Wording is appropriate.
features/exploredash/src/main/res/values-it/strings-explore-dash.xml (1)
252-253: LGTM – Italian session-expired title added.All good.
features/exploredash/src/main/res/values-de/strings-explore-dash.xml (1)
248-249: LGTM – German session-expired title added; base fallback and usage verified.features/exploredash/src/main/res/values-sk/strings-explore-dash.xml (1)
256-257: Translation OK; verify consistency with other locales and base.Text is appropriate. Ensure the key exists in the base values and all ExploreDash locales to prevent missing-resource crashes.
You can reuse the verification script from the PT file comment; it will scan all locales and the base file.
| <string name="token_expired_title">Sua sessão expirou</string> | ||
| </resources> |
There was a problem hiding this comment.
🧩 Analysis chain
Looks good; confirm coverage across locales and base.
String is correct. Please verify token_expired_title exists in the default values and all ExploreDash locales to avoid fallback issues.
Run to verify:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# List all strings-explore-dash.xml files and check for token_expired_title presence
echo "Files missing token_expired_title:"
fd -a 'strings-explore-dash.xml' | while read -r f; do
if ! rg -nP '\bname\s*=\s*"token_expired_title"\b' "$f" >/dev/null; then
echo " - $f"
fi
done
echo
echo "Check default/base locale file:"
fd -a 'features/exploredash/src/main/res/values/strings-explore-dash.xml' || true
if fd -a 'features/exploredash/src/main/res/values/strings-explore-dash.xml' >/dev/null; then
rg -n 'name="token_expired_title"' features/exploredash/src/main/res/values/strings-explore-dash.xml || echo " - Missing in base values"
else
echo " - Base values file not found; ensure a default exists."
fiLength of output: 2258
Add missing localized string token_expired_title
token_expired_title is defined in the default strings-explore-dash.xml but absent in every features/exploredash/src/main/res/values-*/strings-explore-dash.xml; add it to each locale to avoid English fallback.
🤖 Prompt for AI Agents
In features/exploredash/src/main/res/values-pt/strings-explore-dash.xml around
lines 252-253, add the missing localized string entry for token_expired_title
(Portuguese translation "Sua sessão expirou") to match the default
strings-explore-dash.xml; then propagate the same key to every other
features/exploredash/src/main/res/values-*/strings-explore-dash.xml file using
the appropriate locale translations so no locale falls back to English.
HashEngineering
force-pushed
the
prepare-11.4.1
branch
from
c835f2c to
65f7ad7
Compare
| val sendRequestForSigning = SendRequest.forTx(sendRequest.tx) | ||
| val sendRequestForSigning = createSendRequest( | ||
| false, | ||
| basePaymentIntent, | ||
| true, | ||
| sendRequest.ensureMinRequiredFee | ||
| ) |
There was a problem hiding this comment.
This is the fix for piggy cards purchases
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
New Features
Style
Chores