Skip to content

feat: support dual usernames #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HashEngineering wants to merge 16 commits into
base: master
Choose a base branch
from
Open

feat: support dual usernames #1455

HashEngineering wants to merge 16 commits into from

Conversation

@HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Jan 16, 2026

Issue being fixed or feature implemented

Related PR's and Dependencies

There is also a PR to merge for kotlin-platform

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

HashEngineering and others added 16 commits February 26, 2025 14:19
@HashEngineering
feat(dashpay): update create invite to support contested usernames (#…
2019061 
…1343)

* chore: update checkpoints

* fix: activate invite features on testnet

* fix: handle mix dash dialog result

* fix: SendInviteWorker should take value parameter

* fix: add fee and confirm dialog and result fragment

* fix: add fee and confirm dialog and result fragment

* feat: add nav invite history nav graph

* feat: add search user fragment to nav graph

* chore: remove obsolete Invite*Activity classes

* fix: pass caller to Invite History

* fix: simplify function to get number of invites

* fix: other fixes

* fix: add balance check and check pin dialog

* fix: move register/unregister to main thread

* fix: don't publish tx metadata if there is no identity

* feat: update translations

* refactor: LiveData to StateFlow

* feat: add retry/fix, change DB table

* refactor: rename inviteId to fundingAddress

* refactor: simplify InvitationFragment

* feat: add progress circle for loading

* fix: fix errors with creating invites

* fix: problem with frame vs linear layout

* fix: catch errors and handle retry for Restore Identity

* fix: make sure identity is fully restored/created before observingContacts

* fix: prevent transaction observer from updating view if past lifecycle

* fix: save restore state to blockchain identity data

* refactor: rename createInviteFundingTransaction

* fix: ensure that identity funding addresses are not reused

* refactor: update sendInviteLauncher

* fix: allow invites without ISLocks

* fix: start worker in coroutine

* chore: update dashj and dpp

* refactor: improvements

* fix: recover invite

* fix: titles of menus and screens

* fix: show Invitations menu item only if username creation is finished.

* fix: refactor to avoid uninit blockchainIdentity in platform

* fix: refactor to avoid uninit blockchainIdentity in platform

* refactor: move validateIdentity to TopUpRepository

* refactor: orderBy for UsernameSearchResults

* fix: add error handling, logging and cleanup
@HashEngineering
Merge branch 'master' of https://github.com/dashevo/dash-wallet into …
87fba38 
…feature-invites
@HashEngineering
fix: update new events after invite refactoring
9da6e02
@HashEngineering @coderabbitai
feat(dashpay): update and improve receive invite flows (#1365)
9032594 
* feat: update receive invitation feature

* refactor: replace FancyAlertDialog with AdaptiveDialog

* feat: add Username types dialog

* feat: support invites via OnboardingActivity

* fix: updates

* Rename .java to .kt

* refactor: convert AbstractBindServiceActivity to Kotlin

* fix: add getSyncStage to BlockchainStateProvider

* fix: derive AcceptInviteActivity from LockScreenActivity

* fix: improvements and refactoring

* fix: more fixes

* fix: set sources when created

* fix: use correct type with findViewById

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: other issues found by coderabbit

* fix: use background_secondary

* fix: remove withContext for some calls to DataStore get

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@HashEngineering
Merge branch 'master' of https://github.com/dashevo/dash-wallet into …
ffc3fc3 
…feature-invites
@HashEngineering
Merge branch 'master' of https://github.com/dashevo/dash-wallet into …
232e5af 
…feature-invites
@HashEngineering
feat: improve and simplify receiving invitations (#1382)
4f9110c 
* feat: update More Screen

* feat: update onboarding

* feat: update InviteHandler

* feat: update home screen

* chore: remove commented code

* chore: remove unused classes and layouts

* fix: remove handler if onboarding

* fix: more improvements

* fix: more improvements

* chore: remove dead code

* fix: more improvements

* feat: use compose for the onboarding buttons

* feat: hide Restore from file unless DEBUG

* feat: adjust padding inside button

* chore: remove commented code

* chore: cleanup

* fix: updates for text, etc

* fix: app switching after receiving invite

* fix: use the same address provided to the worker

fix: use transaction time for Invitations that are restored

* fix: missing context crash

* fix: voting period error dialog

* fix: activating invites goes to home screen

* fix: prevent proceeding before username validation

* fix: prevent proceeding before username validation

* fix: change flow after receiving invite

* fix: rescan wallet resets some data in BlockchainService

* fix: improve logging in InviteHandlerActivity

* fix: MixDashFirstDialog skip button fix on Home Screen

* fix: prevent crash on upgrade with no wallet

* chore: add more comments on TopUpRepository

* chore: removed commented lines

* fix: remove obsolete onIdentityResolved
@HashEngineering
Merge branch 'master' of https://github.com/dashevo/dash-wallet into …
9df2ab4 
…feature-invites
@HashEngineering
Merge branch 'master' of https://github.com/dashevo/dash-wallet into …
7edbffb 
…feature-invites
@HashEngineering
feat(dashpay): replace dynamic links from Firebase with AppsFlyer (#1410
dc2bfca 
)

* fix: various updates to support new features from master

* feat: add appsflyer for deep linking

* feat: add appsflyer social media links

* tests: add AppsFlyerLinkIntegrationTest

* fix: simplify InvitationLinkData

* refactor: TopUpRepository

* fix: allow dashwallet://invite

* chore: remove commented code

* chore: add proguard rules for appsflyer
@HashEngineering
Merge branch 'master' of https://github.com/dashevo/dash-wallet into …
e203a37 
…feature-invites
@HashEngineering
fix: merge fixes
3484bd7
@HashEngineering
Merge branch 'master' of https://github.com/dashevo/dash-wallet into …
9f8014f 
…feat/dual-usernames
@HashEngineering
feat: support dual username creation (#1431)
af97c9f 
* refactor: rename BlockchainIdentityData.CreationState to IdentityCreationState

* refactor:  make BlockchainIdentityData be derived from BlockchainIdentityBaseData

* refactor: move username request classes to the request package

* feat: update flow by removing unnecessary screen

* refactor: move username voting screens to voting package

* feat: support instant username creation

* feat: support instant username creation (UI)

* fix: fix many issues with instant username creation and displaying that name

* fix: UI issues

* fix: UI issues (more menu)

* fix: improve tracking of asset lock transactions

* refactor: rename some functions

* fix: UI issues

* docs: add Claude agent files

* fix: fix race condition when saving profiles with image urls

* fix: fix race condition when sending asset lock transactions

* fix: UI flow

* fix: create instant username before non-contested

* fix: make wallet wipe destroy datastores as serial operations

* fix: shutdown CreateIdentityService during wallet reset

* fix: check voting status for requested username

* chore: fix staging and devnet insight urls

* fix: show request details when username request was rejected

* fix: show request details when username request was rejected

* fix: import private key links for staging and devnet

* fix: consider usernameType in RequestUsernameFragment

* fix: add logging

* fix: various fixes

* fix: error handling

* fix: add CLAUDE.md

* fix: repair retry during username requests

* fix: repair retry during username requests

* fix: use dpp 2.0.3-SNAPSHOT
@HashEngineering
feat (dashpay): dual usernames network (#1447)
20e0a6f 
* fix: use viewLifecycleOwner in ContactsFragment

* fix: add padding to the requested username item

* fix: use viewLifecycleOwner in MoreFragment

* fix: improve updating of MoreFragment when as blockchain identity is updated

* fix: don't show non-contested names if contested names are in the results

* fix: update contact profiles when a dashpay profile is missing
@HashEngineering
feat: support dual username restore (#1448)
9c9162e 
* refactor: rename BlockchainIdentityData.CreationState to IdentityCreationState

* refactor:  make BlockchainIdentityData be derived from BlockchainIdentityBaseData

* refactor: move username request classes to the request package

* feat: update flow by removing unnecessary screen

* refactor: move username voting screens to voting package

* feat: support instant username creation

* feat: support instant username creation (UI)

* fix: fix many issues with instant username creation and displaying that name

* fix: UI issues

* fix: UI issues (more menu)

* fix: improve tracking of asset lock transactions

* refactor: rename some functions

* docs: add Claude agent files

* fix: fix race condition when saving profiles with image urls

* fix: fix race condition when sending asset lock transactions

* fix: create instant username before non-contested

* fix: make wallet wipe destroy datastores as serial operations

* fix: shutdown CreateIdentityService during wallet reset

* fix: check voting status for requested username

* chore: fix staging and devnet insight urls

* fix: show request details when username request was rejected

* fix: show request details when username request was rejected

* fix: import private key links for staging and devnet

* fix: consider usernameType in RequestUsernameFragment

* fix: add logging

* fix: various fixes

* fix: error handling

* fix: add CLAUDE.md

* fix: repair retry during username requests

* fix: repair retry during username requests

* fix: use dpp 2.0.3-SNAPSHOT

* fix: use viewLifecycleOwner in ContactsFragment

* fix: add padding to the requested username item

* fix: use viewLifecycleOwner in MoreFragment

* fix: improve updating of MoreFragment when as blockchain identity is updated

* fix: don't show non-contested names if contested names are in the results

* fix: update contact profiles when a dashpay profile is missing

* feat: support dual username restore

* feat: remove obsolete restoreIdentity

* fix: update UI for failed contested names with instant names

* fix: add lostVote to BlockchainIdentityBaseData

* fix: only check invites if the feature is on

* fix: other fixes for restoring usernames

* fix: address coderabbit feedback
@HashEngineering HashEngineering self-assigned this Jan 16, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Too many files!

24 files out of 174 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@HashEngineering HashEngineering

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HashEngineering