Skip to content

feat: introduce basic extended addresses implementation, stop using platform{HTTP,P2P}Port #6666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from
Draft

feat: introduce basic extended addresses implementation, stop using platform{HTTP,P2P}Port #6666

wants to merge 23 commits into from

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented May 12, 2025 •
edited
Loading

Additional Information

Breaking Changes

Work in progress.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 23 milestone May 12, 2025
@kwvg kwvg mentioned this pull request May 15, 2025
Draft
5 tasks
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please rebase.

kwvg added 12 commits May 16, 2025 12:40
@kwvg
evo: introduce type-flexible NetInfoEntry to allow non-CService data
d73aa0a
@kwvg
evo: ensure the ADDRV2 serialization is always used in NetInfoEntry
8a9d249
@kwvg
evo: change internal type of MnNetInfo to NetInfoEntry
34687b1
@kwvg
evo: return MnNetInfo::GetEntries() with NetInfoEntry
b9d5319
@kwvg
evo: utilize NetInfoEntry::IsTriviallyValid() in ProTx trivial checks
ee6cf6f 
Also, ProRegTx allows an empty netInfo, ProUpServTx does not, so we
should check that ProUpServTx::netInfo isn't empty.
@kwvg
evo: prohibit overwriting entry in MnNetInfo
e49f8e3
@kwvg
evo: fast-fail MnNetInfo::AddEntry() if invalid characters found
c3e48ab
@kwvg
evo: make netInfo a shared pointer
e5e8974
@kwvg
evo: introduce NetInfoInterface, make MnNetInfo an implementation
89c89d3
@kwvg
evo: use interface shared ptr for netInfo instead of implementation
59a5e75
@kwvg
evo: allow deciding NetInfoInterface impl based on object version
1f3afb3
@kwvg
evo: introduce new ProTx version for extended addresses (ExtNetInfo)
227b428
kwvg added 9 commits May 16, 2025 16:59
@kwvg
evo: introduce ExtNetInfo, limit to 32 entries per purpose code
341f049
@kwvg
evo: prohibit partial duplicates in ExtNetInfo
c9b2f8f 
MnNetInfo cannot store duplicate entries as it can only store one entry.
@kwvg
evo: introduce versioning for ExtNetInfo
0a2ef81
@kwvg
evo: require the primary (i.e. first) entry to use IPv4
d896ea2 
MnNetInfo only accepts one entry and only accepts IPv4 so no additional
logic is needed there.
@kwvg
evo: introduce the ability to store multiple lists of addresses
2263e6c
@kwvg
evo: allow partial duplicates across entry lists
a11c6a1 
Needed to allow storing multiple sets as the same address may be hosting
a different purpose with a different port.
@kwvg
evo: allow storing platform p2p and http addresses in ExtNetAddr
b15f5e9
@kwvg
evo: allow and recognize CJDNS addresses
e825694
@kwvg
evo: recognize and store I2P and onion domains in ExtNetInfo
3459c64
@kwvg
evo: introduce purpose-based port restrictions
e2f1a8f 
Additionally, ports defined as defaults are exempt from bad port
restrictions for that purpose. In other purposes, they are still
considered bad ports.
@kwvg kwvg mentioned this pull request May 18, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23
Development

Successfully merging this pull request may close these issues.
1 participant
@kwvg