feat(sdk): token and group queries #2449
Conversation
WalkthroughThis PR expands support for token and group operations across multiple modules. It increases the versioned request/response arrays in the gRPC layer and adds new gRPC implementations for additional token and group types. Conditional compilation is introduced to derive serialization traits for certain structs when the "fixtures-and-mocks" feature is enabled. Genesis state creation and SDK test data functions are enhanced, and various tests covering token queries and group actions are added. Several error handling, dependency, and import adjustments are also included, along with removals of outdated diagnostic files. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant PlatformGrpcClient
participant Server
Client->>PlatformGrpcClient: Send GetTokenStatusesRequest (or similar)
PlatformGrpcClient->>Server: Process request
Server-->>PlatformGrpcClient: Return corresponding Response
PlatformGrpcClient-->>Client: Deliver response
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
shumkov
force-pushed
the
feat/sdk/queries
branch
from
5d54570 to
21de3a4
Compare
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (25)
packages/rs-drive-proof-verifier/src/tokens/token_total_supply.rs (1)
30-35: Consider future-proofing version handling.Currently, the code only handles
Version::V0. If future versions are introduced, you may want to include a fallback match arm or a more explicit error message for unsupported versions.packages/rs-drive-proof-verifier/src/tokens/token_status.rs (1)
36-45: Account for potential new versions.Similar to the token total supply logic, consider adding a match arm for future versions, or provide an explicit error for unsupported versions to make this more robust.
packages/rs-sdk/src/platform/tokens/identity_token_balances.rs (2)
14-21: Consider validating non-empty token IDs.If your business logic requires at least one token, add checks or return a more explicit error when
token_idsis empty.
44-50: Validate identity IDs if needed.If your use case mandates at least one identity, ensure the code handles an empty
identity_idsarray appropriately.packages/rs-sdk/src/platform/group_actions.rs (1)
50-105: Potential code duplication among multiple queries
GroupInfosQueryand similar query structs below share a near-identical pattern of defining a struct with optional fields and implementingQuery<...>. If code reuse or maintainability becomes an issue, consider a macro or templated approach to reduce boilerplate.packages/rs-drive-proof-verifier/src/tokens/identity_token_balance.rs (1)
132-198: Consistent approach in multi-identity proof
Themaybe_from_proof_with_metadatamethod follows the same robust verification pattern. The repeated logic might benefit from a shared utility function if this pattern continues in other modules.packages/rs-drive-proof-verifier/src/tokens/token_info.rs (2)
85-85: Potential debug printing
There's aprintln!statement at line 85 that logs the proof in hex. Consider removing or gating it behind a debug feature flag to prevent unintentional large or sensitive logs in production.- println!("{:?}", hex::encode(&proof.grovedb_proof)); + // println!("{:?}", hex::encode(&proof.grovedb_proof));
133-198: Robust multi-identity info verification
Again, the pattern of verifying the proof, mapping errors, and returning(Option<Self>, ResponseMetadata, Proof)is well-written. If you foresee more repeated proof-verification flows, refactoring into a shared helper might further optimize code reuse.packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs (3)
50-103: Consider splitting or renaming this function for improved clarity.The
create_data_for_group_token_queriesfunction performs a variety of operations (identity registration, data contract creation, token minting, freezing, pausing, and adding group actions). This goes beyond simply "creating data." Splitting it into smaller functions or clarifying the name can help enhance readability and maintainability.
72-82: Clarify the comment on which token is being paused."Pause token 2" might be confusing if you are referring to the token indexed at
TOKEN_ID_2. Currently, the code usesTOKEN_ID_1, which is the "second" token in a zero-based index. Consider adjusting the comment for consistency:- // Pause token 2 + // Pause the second token (TOKEN_ID_1)
120-121: Confirm the handling of private keys.There's a comment hinting that private keys may be printed, but no actual logging takes place. If printing or logging is needed for debugging, add the relevant code. Otherwise, remove or revise the comment to avoid confusion.
packages/rs-drive-proof-verifier/src/group_actions.rs (1)
87-167: Consider factoring out shared logic.This logic for extracting request fields, verifying proofs, and mapping results repeats across the file. Extracting it into a helper method or utility could reduce duplication and enhance maintainability.
packages/rs-sdk/src/platform/tokens/mod.rs (1)
3-4: Fix incorrect documentation comment.The documentation comment for
token_infomodule is incorrect as it's a copy of theidentity_token_balancesmodule's comment.Apply this diff to fix the documentation:
-/// Identity token balances queries +/// Token information queriespackages/rs-drive-proof-verifier/src/tokens/mod.rs (1)
1-2: Maintain consistent module naming across packages.The module name
identity_token_balance(singular) in the proof verifier differs fromidentity_token_balances(plural) in the SDK. Consider using consistent naming to improve maintainability.Apply this diff to align with the SDK's naming:
-pub mod identity_token_balance; +pub mod identity_token_balances;packages/rs-sdk/tests/fetch/tokens/token_total_supply.rs (1)
8-14: Consider adding more test cases.While the test setup is correct, consider adding test cases for:
- Invalid token IDs
- Error handling scenarios
- Edge cases with different supply values
packages/rs-sdk/src/platform/tokens/token_total_supply.rs (1)
7-20: Consider adding input validation.While the Query implementation is correct, consider adding validation for the token ID before creating the request.
impl Query<GetTokenTotalSupplyRequest> for Identifier { fn query(self, prove: bool) -> Result<GetTokenTotalSupplyRequest, Error> { + if self.is_empty() { + return Err(Error::InvalidInput("Token ID cannot be empty".into())); + } let request = GetTokenTotalSupplyRequest { version: Some(get_token_total_supply_request::Version::V0(packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/mod.rs (1)
17-32: Consider adding logging for test data generation.While the implementation is correct, adding debug logs would help track test data generation during testing.
pub(super) fn create_sdk_test_data( &self, block_info: &BlockInfo, transaction: TransactionArg, platform_version: &PlatformVersion, ) -> Result<(), Error> { + log::debug!("Creating SDK test data for local network"); if self.config.network != Network::Regtest { return Err(Error::Execution(ExecutionError::CorruptedCodeExecution( "create_sdk_test_data must be called only on local network", ))); } self.create_data_for_group_token_queries(block_info, transaction, platform_version)?; + log::debug!("SDK test data creation completed"); Ok(()) }packages/rs-sdk/tests/fetch/tokens/token_status.rs (1)
21-22: Improve error handling in test expectation.The current error message doesn't match the actual operation being performed.
.await - .expect("fetch identity token infos"); + .expect("fetch token statuses");packages/rs-sdk/src/platform.rs (1)
3-6: Consider documenting new modules.While the module additions align with the PR objectives, they should be documented similar to other modules in the file. Also, the TODO comment suggests a future refactor - consider creating a tracking issue.
Would you like me to help create a tracking issue for the TODO regarding proper user-facing API design?
Also applies to: 20-21
packages/rs-sdk/tests/fetch/group_actions.rs (2)
60-87: Consider removing the debug print statement.The test effectively validates group fetching with pagination. However, the
dbg!statement on line 78 should be removed as it's not necessary for the test.- dbg!(&groups);
126-156: Consider removing the debug print statement.The test effectively validates group action fetching. However, the
dbg!statement on line 148 should be removed as it's not necessary for the test.- dbg!(&group_actions);packages/rs-sdk/src/mock/requests.rs (1)
287-424: Consider reducing code duplication in mock implementations.The serialization/deserialization logic is very similar across
IdentityTokenInfos,IdentitiesTokenInfos,TokenStatuses, andGroupActions. Consider extracting the common pattern into a macro or helper function.Example macro approach:
macro_rules! impl_mock_response_for_retrieved_values { ($type:ty, $value_type:ty) => { impl MockResponse for $type { fn mock_serialize(&self, sdk: &MockDashPlatformSdk) -> Vec<u8> { let vec: Vec<(Identifier, Option<$value_type>)> = self.iter().map(|(k, v)| (*k, v.clone())).collect(); platform_encode_to_vec(vec, BINCODE_CONFIG, sdk.version()) .expect(concat!("encode ", stringify!($type))) } fn mock_deserialize(sdk: &MockDashPlatformSdk, buf: &[u8]) -> Self where Self: Sized, { let vec: Vec<(Identifier, Option<$value_type>)> = platform_versioned_decode_from_slice(buf, BINCODE_CONFIG, sdk.version()) .expect(concat!("decode ", stringify!($type))); RetrievedValues::from_iter(vec) } } }; } // Usage: impl_mock_response_for_retrieved_values!(IdentityTokenInfos, IdentityTokenInfo); impl_mock_response_for_retrieved_values!(IdentitiesTokenInfos, IdentityTokenInfo); impl_mock_response_for_retrieved_values!(TokenStatuses, TokenStatus); impl_mock_response_for_retrieved_values!(GroupActions, GroupAction);packages/rs-sdk/Cargo.toml (1)
62-63: Track the TODO comment about removing features from default.The comment indicates that
mocksandoffline-testingshould be removed from default features in the future.Would you like me to create an issue to track this technical debt?
packages/rs-sdk/README.md (2)
96-98: Clarify Test Vector Generation InstructionsThe updated steps clearly instruct developers to (1) uncomment the
create_sdk_test_data(...)call, (2) run thegenerate_test_vectors.shscript, and (3) optionally commit the generated vectors.Suggestion: Consider adding a brief note clarifying whether generated test vector files should be committed or ignored (for example, via a .gitignore rule) to prevent accidental pollution of the repository.
146-147: Review Duplicate Checklist StepsThe checklist now contains duplicate instructions for:
- Uncommenting
create_sdk_test_data(...)(see step 2 on line 96 and step 15 on line 146), and- Generating test vectors (step 3 on line 97 versus step 16 on line 147).
Please confirm whether both occurrences are necessary or if these steps can be consolidated to avoid confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (82)
packages/dapi-grpc/build.rs(3 hunks)packages/rs-dapi-client/src/transport/grpc.rs(1 hunks)packages/rs-dpp/src/balances/total_single_token_balance/mod.rs(1 hunks)packages/rs-dpp/src/tokens/info/mod.rs(2 hunks)packages/rs-dpp/src/tokens/info/v0/mod.rs(1 hunks)packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/mod.rs(2 hunks)packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/mod.rs(1 hunks)packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/src/group_actions.rs(1 hunks)packages/rs-drive-proof-verifier/src/lib.rs(1 hunks)packages/rs-drive-proof-verifier/src/tokens/identity_token_balance.rs(1 hunks)packages/rs-drive-proof-verifier/src/tokens/mod.rs(1 hunks)packages/rs-drive-proof-verifier/src/tokens/token_info.rs(1 hunks)packages/rs-drive-proof-verifier/src/tokens/token_status.rs(1 hunks)packages/rs-drive-proof-verifier/src/tokens/token_total_supply.rs(1 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_33_46-3251.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_00-10108.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_04-10384.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_08-10643.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_12-10937.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_20-11458.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_23-11733.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_25-11999.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_26-12247.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_28-12710.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_29-12958.txt(0 hunks)packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_30-13195.txt(0 hunks)packages/rs-platform-value/src/types/identifier.rs(1 hunks)packages/rs-sdk/Cargo.toml(2 hunks)packages/rs-sdk/README.md(3 hunks)packages/rs-sdk/src/mock/requests.rs(6 hunks)packages/rs-sdk/src/mock/sdk.rs(1 hunks)packages/rs-sdk/src/platform.rs(1 hunks)packages/rs-sdk/src/platform/group_actions.rs(1 hunks)packages/rs-sdk/src/platform/tokens/identity_token_balances.rs(1 hunks)packages/rs-sdk/src/platform/tokens/mod.rs(1 hunks)packages/rs-sdk/src/platform/tokens/token_info.rs(1 hunks)packages/rs-sdk/src/platform/tokens/token_status.rs(1 hunks)packages/rs-sdk/src/platform/tokens/token_total_supply.rs(1 hunks)packages/rs-sdk/tests/fetch/config.rs(3 hunks)packages/rs-sdk/tests/fetch/contested_resource_vote_state.rs(1 hunks)packages/rs-sdk/tests/fetch/generated_data.rs(1 hunks)packages/rs-sdk/tests/fetch/group_actions.rs(1 hunks)packages/rs-sdk/tests/fetch/mod.rs(1 hunks)packages/rs-sdk/tests/fetch/tokens/identity_token_balances.rs(1 hunks)packages/rs-sdk/tests/fetch/tokens/mod.rs(1 hunks)packages/rs-sdk/tests/fetch/tokens/token_info.rs(1 hunks)packages/rs-sdk/tests/fetch/tokens/token_status.rs(1 hunks)packages/rs-sdk/tests/fetch/tokens/token_total_supply.rs(1 hunks)packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/data_contract-e668c659af66aee1e72c186dde7b5b7e0a1d712a09c40d5721f622bf53c53155.json(1 hunks)packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json(0 hunks)
⛔ Files not processed due to max files limit (31)
- packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
- packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
💤 Files with no reviewable changes (28)
- packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_33_46-3251.txt
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_04-10384.txt
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_00-10108.txt
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_20-11458.txt
- packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_23-11733.txt
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_12-10937.txt
- packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_08-10643.txt
- packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_25-11999.txt
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_29-12958.txt
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_26-12247.txt
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_30-13195.txt
- packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_28-12710.txt
✅ Files skipped from review due to trivial changes (1)
- packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/data_contract-e668c659af66aee1e72c186dde7b5b7e0a1d712a09c40d5721f622bf53c53155.json
🧰 Additional context used
📓 Learnings (9)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
🪛 Biome (1.9.4)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
[error] 1-1: String values must be double quoted.
(parse)
🔇 Additional comments (70)
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Intentional Test Vector Hash AdditionThe added hash value is used as a test vector for validating data contract reads. The file intentionally does not follow standard JSON formatting, which aligns with project-specific practices for mock test data.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Intentional Non-Standard JSON Format for Test DataThe file introduces a single-line hash value without the typical double quotes expected in standard JSON. This deviation is intentional according to the project's testing framework, which accepts non-standard JSON formats for mock data files.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Intentionally Non-Standard JSON Format is AcceptableThe file contains a hash value in plain text without double quotes, which deviates from strict JSON formatting. This is intentional for test vectors in this directory—as noted in previous learnings—even though static analysis flags it. The added newline at the end ensures proper file termination.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-drive-proof-verifier/src/tokens/token_total_supply.rs (1)
44-63: Implementation looks correct.The logic properly verifies the token total supply proof and aggregated identity balance, and the error handling for GroveDB proof parsing appears solid.
packages/rs-drive-proof-verifier/src/tokens/token_status.rs (1)
54-64: Approach looks valid.Your approach to verifying token statuses and mapping errors to
GroveDBErroris consistent with the rest of the codebase.packages/rs-sdk/src/platform/tokens/identity_token_balances.rs (1)
52-69: Well-structured query construction.The creation of gRPC request objects and integration with the
FetchManytrait aligns nicely with the SDK's existing patterns.packages/rs-sdk/src/platform/group_actions.rs (5)
23-30: Well-structured group query definition
TheGroupQuerystruct and its fields are clearly documented and self-explanatory. Nice use of doc comments to clarify each field's purpose.
32-45: Proper request construction
Theimpl Query<GetGroupInfoRequest>cleanly instantiates the request struct. Consider adding additional validation logic (e.g., whethergroup_contract_positionis valid) if there's a possibility of out-of-range values.Would you like me to generate a script to search for all potential out-of-range casts of
GroupContractPosition?
46-49: Simple, consistent fetch interface
Usingimpl Fetch for Groupis straightforward for bridging the entity with the request type.
106-132: Handled optional start action ID effectively
Your approach of mapping(Identifier, StartAtIncluded)directly into the request struct is clean and readable. Make sure that usage in other modules is consistent with how optional start IDs are handled here.
134-168: Consistent approach for group action signers
TheGroupActionSignersQuerystruct and itsQuery<GetGroupActionSignersRequest>implementation mirror the earlier patterns, keeping the codebase consistent. Good job ensuring all relevant fields (contract ID, position, status, action ID) map to the request.packages/rs-drive-proof-verifier/src/tokens/identity_token_balance.rs (3)
17-39: Clean newtype for identity token balances
WrappingRetrievedObjects<Identifier, TokenAmount>inIdentityTokenBalancesis a neat way to provide domain-specific meaning. This pattern helps keep the code self-documenting.
41-107: Robust proof verification flow
Theimpl FromProof<GetIdentityTokenBalancesRequest>carefully validates the request, checks for missing metadata, and callsDrive::verify_token_balances_for_identity_id. The error mapping forGroveDBErrorto a custom error type is well done. This ensures precise error reporting.
108-130: Same pattern extended for multiple identities
Similar toIdentityTokenBalances,IdentitiesTokenBalanceswrapsRetrievedObjects<Identifier, TokenAmount>. TheFromIteratorimplementation is a nice convenience, allowing flexible construction.packages/rs-drive-proof-verifier/src/tokens/token_info.rs (3)
17-39: Clear domain structure for token infos
IdentityTokenInfosprovides a straightforward domain type for mapping token IDs toIdentityTokenInfo. DerivingFromandDerefis a simple yet powerful design, facilitating easy iteration and access.
41-107: Solid request and proof handling
Theimpl FromProof<GetIdentityTokenInfosRequest>workflow is carefully laid out, including error handling for invalid 32-byte conversions and thorough proof checks. Great attention to detail with returningError::RequestErrorwhen conversions fail.
110-130: Similar approach for multiple identities
IdentitiesTokenInfosmirrors the single-identity struct, which is helpful for maintaining a uniform mental model of token info retrieval.packages/rs-drive-proof-verifier/src/group_actions.rs (3)
21-82: Implementation looks clear and correct.The proof verification flow and error handling are well structured.
172-278: Implementation aligns with the established pattern.Everything here follows the same approach as previous blocks, ensuring consistency and clarity. No specific issues found.
283-368: No issues detected here.Code is consistent with other proof-verification methods in this file.
packages/rs-sdk/tests/fetch/tokens/mod.rs (1)
1-4: Modules look good.These new modules logically partition token-related tests, improving test organization.
packages/rs-drive-proof-verifier/src/lib.rs (1)
18-21: LGTM!The new module declarations are properly documented and well-organized.
packages/rs-dpp/src/tokens/info/v0/mod.rs (1)
3-4: LGTM!The conditional serialization support is properly implemented with appropriate feature flags.
Also applies to: 7-7
packages/rs-sdk/tests/fetch/tokens/token_total_supply.rs (2)
1-7: LGTM! All necessary imports are present.The imports cover all required dependencies for testing token total supply functionality.
16-26: Verify the hardcoded test values.The test asserts specific values (100200) for both
token_supplyandaggregated_token_account_balances. Ensure these values match the expected test data setup.Run this script to verify the test data setup:
✅ Verification successful
Test values confirmed as correct.
The grep results show that the aggregated test data for token supply is consistently set to 100200. Although the identity token balances test for TOKEN_ID_0 expects 100100, note that the total supply calculation (based on aggregation) for TOKEN_ID_0 returns 100200—which aligns with the test data setup (matching the value for TOKEN_ID_1 in identity token balances). The hardcoded values in the token_total_supply test (both fortoken_supplyandaggregated_token_account_balances) correctly reflect the intended test data.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify test data setup for token supply values # Search for token supply constant definitions or test data setup rg -A 5 "TOKEN_ID_0|100200" packages/rs-sdk/tests/Length of output: 5312
packages/rs-sdk/tests/fetch/mod.rs (1)
21-22: LGTM! New modules are properly organized.The new modules
generated_data,group_actions, andtokensare correctly placed under themocksfeature flag, maintaining consistency with the existing structure.Also applies to: 30-30
packages/rs-sdk/src/platform/tokens/token_total_supply.rs (1)
22-24: LGTM! Fetch trait implementation is correct.The implementation correctly associates TotalSingleTokenBalance with GetTokenTotalSupplyRequest.
packages/rs-sdk/src/platform/tokens/token_status.rs (1)
26-28: LGTM! FetchMany trait implementation is correct.The implementation correctly associates TokenStatus with GetTokenStatusesRequest.
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/mod.rs (1)
23-27: LGTM! Good network restriction check.The function correctly restricts test data generation to local networks only, with appropriate error handling.
packages/rs-sdk/tests/fetch/tokens/token_status.rs (1)
24-29: LGTM! Comprehensive test assertions.The test effectively verifies all token status scenarios including existing, non-existing, and paused tokens.
packages/rs-dpp/src/tokens/info/mod.rs (1)
9-10: LGTM! Well-structured conditional serialization.The addition of serialization traits under the "fixtures-and-mocks" feature flag is appropriate and well-implemented.
Also applies to: 27-27
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/mod.rs (2)
10-10: LGTM! New test module added.The addition of the test module aligns with the PR objectives for implementing token and group queries.
46-51: Improved error handling with future test data generation support.Good improvements:
- Using the
?operator for better error propagation- The commented code indicates planned support for SDK test data generation, which aligns with the PR objectives.
Please ensure the
create_sdk_test_datafunction in the test module is properly implemented and tested before uncommenting line 49.packages/rs-dpp/src/balances/total_single_token_balance/mod.rs (1)
3-6: LGTM! Clean implementation of conditional serialization.The addition of
EncodeandDecodetraits with feature flag is well-structured and follows Rust best practices.Also applies to: 11-11
packages/rs-sdk/src/platform/tokens/token_info.rs (3)
12-39: LGTM! Well-structured implementation of IdentityTokenInfosQuery.The implementation is clean, type-safe, and follows SDK patterns for query handling.
41-68: LGTM! Well-structured implementation of IdentitiesTokenInfosQuery.The implementation properly handles multiple identity IDs for a single token.
70-70: Address the TODO comment for Fetch trait implementation.The Fetch trait implementation is missing and should be completed for full functionality.
Would you like me to help implement the Fetch trait or create an issue to track this task?
packages/rs-sdk/tests/fetch/generated_data.rs (3)
7-9: Consider moving DPNS_DASH_TLD_DOCUMENT_ID to data-contracts crate.The TODO comment suggests a valid improvement in code organization.
Would you like me to help create an issue to track moving this constant to the data-contracts crate?
14-33: LGTM! Well-documented constants with clear references.The constants are well-organized and properly documented with references to their initialization code.
34-45: LGTM! Efficient use of LazyLock for token IDs.Good use of
LazyLockfor computing token IDs lazily, which improves performance by calculating values only when needed.packages/rs-sdk/tests/fetch/tokens/token_info.rs (3)
13-38: LGTM! Well-structured test with good coverage.The test effectively validates token info fetching for both frozen and non-existent tokens, with clear assertions and pattern matching.
40-68: LGTM! Good test coverage for unknown token scenarios.The test effectively validates that unknown token IDs return
Nonefor all identities, with clear assertions.
70-100: LGTM! Comprehensive test for token info across multiple identities.The test effectively validates token info fetching using a calculated token ID, with good coverage of both frozen and non-existent cases.
packages/rs-sdk/tests/fetch/tokens/identity_token_balances.rs (3)
15-38: LGTM! Well-structured test with precise balance assertions.The test effectively validates token balances for both existing and unknown tokens, with clear numeric assertions.
40-73: LGTM! Good test coverage for unknown token scenarios.The test effectively validates that unknown token IDs return
Nonefor all identities, with clear assertions.
75-110: LGTM! Comprehensive test for token balances across multiple identities.The test effectively validates various balance states using a calculated token ID, with good coverage of different scenarios (large balance, small balance, and no balance).
packages/rs-sdk/tests/fetch/group_actions.rs (5)
18-34: LGTM! Good negative test case.The test effectively validates the behavior when attempting to fetch a non-existing group.
36-58: LGTM! Well-structured test with good pattern matching.The test effectively validates the structure and content of an existing group.
89-124: LGTM! Comprehensive test for fetching multiple groups.The test effectively validates fetching multiple groups with inclusive start position, with good pattern matching for each group's structure.
158-188: LGTM! Well-structured test for paginated group action fetching.The test effectively validates fetching a single group action with pagination parameters.
190-211: LGTM! Clear test for group action signers.The test effectively validates fetching and verifying group action signers.
packages/rs-sdk/tests/fetch/config.rs (1)
185-185: LGTM! Good improvement to builder flexibility.Making the builder mutable allows for better configuration flexibility during SDK setup.
packages/rs-platform-value/src/types/identifier.rs (1)
147-147: Great optimization using const fn!Converting
newto a const function allows for compile-time evaluation of identifiers, which can improve performance in scenarios where identifiers are created as constants.packages/dapi-grpc/build.rs (1)
50-91: LGTM! New request and response types added for token and group queries.The changes properly extend the versioned messages support with new token and group-related types. The duplicate checking ensures message uniqueness is maintained.
Also applies to: 98-138
packages/rs-sdk/tests/fetch/contested_resource_vote_state.rs (1)
110-110: LGTM! Updated error message format in test.Test updated to match the new transport error message format, maintaining test accuracy.
packages/rs-sdk/src/mock/requests.rs (1)
229-230: LGTM! Improved code clarity by removing unnecessary parentheses.The change improves readability without affecting functionality.
Also applies to: 245-246
packages/rs-sdk/src/mock/sdk.rs (1)
201-230: LGTM! The implementation of new token and group request types is well-structured.The changes properly integrate token and group-related request types into the mock SDK, following the established patterns and maintaining consistent error handling.
packages/rs-dapi-client/src/transport/grpc.rs (1)
518-606: LGTM! The gRPC transport implementations for token and group requests are well-implemented.The changes properly implement the
TransportRequesttrait for all new request types, following the established patterns and using appropriate default settings.packages/rs-drive-proof-verifier/Cargo.toml (1)
33-33: LGTM! The addition of the state-transition-signing feature enhances security.The new feature is properly integrated into the dpp dependency features list.
packages/rs-sdk/Cargo.toml (1)
72-72: LGTM! The addition of fixtures-and-mocks feature enhances testing capabilities.The new feature is properly integrated into the mocks feature list.
packages/rs-sdk/README.md (1)
16-16: Correct Dependency DeclarationThe dependency declaration for
dash-sdknow correctly points to the GitHub repository (https://github.com/dashpay/platform). Please verify that this URL and its branch or version alignment meet the project's expectations.packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Mock Data File ReviewThis file contains a single hash value that does not adhere to standard JSON formatting (e.g. lacking double quotes). According to our established testing framework and prior learnings, such deviations are intentional for these mock data files.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Mock Data File ReviewThe appended hash string serves as a test vector. Although it does not conform to standard JSON syntax (e.g. missing double quotes), this is acceptable for the project's mock data format.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Mock Data File ReviewThe single-line hash value in this file is intended as mock data. Despite not using standard JSON double quoting, this format is in line with the project's testing guidelines.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Mock Data File ReviewThis test vector file contains a hash string that deviates from strict JSON formatting (e.g. missing double quotes). Such formatting is intentional and acceptable for mock data as per the project's standards.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Intentionally Non-Standard JSON Format for Mock DataThe file introduces a hash value intended for use in test vectors. Although static analysis suggests that string values should be double quoted, this non-standard formatting is intentional and accepted within the project's testing framework.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Valid Mock Data Entry with Intentional FormatThis file adds a new hash value used as mock data for scenarios where contested resource vote states are not found. Despite the static analysis note regarding double quoting, the retrieved learnings confirm that the current format is by design.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Consistent Mock Data Format for Document List Drive QueryThe file contains a single hash value intended for testing document list drive queries. The format, while not standard JSON due to the lack of double quotes, is acceptable per the project’s established pattern for mock data files.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Appropriate Test Vector for Document Read (No Document) ScenarioThis file adds a hash value for a document-read test case where no document is found. Although static analysis flags the missing double quotes, this non-standard representation is intentional and conforms with the project's testing framework for mock files.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)
1-1: Valid and Consistent Mock Data for Document ReadThe file introduces a hash value for the document read test vector. The format chosen here—omitting double quotes—is intentional for test robustness and aligns with our project's practices for mock JSON files.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
...list/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
Outdated
Show resolved
Hide resolved
...rent/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
Outdated
Show resolved
Hide resolved
...-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs
Outdated
Show resolved
Hide resolved
...ract/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs (1)
50-105: Rename misleading comment to match the actual token index.
“Pause token 2” actually pausesTOKEN_ID_1. A clearer comment reduces confusion for readers.- // Pause token 2 + // Pause token #1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/mod.rs(2 hunks)packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs(1 hunks)packages/rs-drive-abci/src/platform_types/platform/mod.rs(1 hunks)packages/rs-drive/Cargo.toml(1 hunks)packages/rs-platform-version/Cargo.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/rs-platform-version/Cargo.toml
- packages/rs-drive/Cargo.toml
🧰 Additional context used
🧠 Learnings (1)
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs (1)
Learnt from: shumkov
PR: dashpay/platform#2449
File: packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs:35-38
Timestamp: 2025-02-14T04:31:17.170Z
Learning: In test scenarios, it's acceptable for different types of identifiers (e.g., identity IDs and contract IDs) to share the same byte values since they operate in different scopes and contexts.
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: Rust packages (rs-dapi-client) / Tests
- GitHub Check: Rust packages (rs-dapi-client) / Linting
- GitHub Check: Rust packages (rs-dapi-client) / Formatting
- GitHub Check: Rust packages (rs-dapi-client) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Rust packages (dpp) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dash-sdk) / Tests
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (8)
packages/rs-drive-abci/src/platform_types/platform/mod.rs (2)
184-185: Code improvement: Simplified protocol version mappingThe code has been simplified by directly passing the function reference to
mapinstead of using a closure, resulting in more concise and readable code.
181-181:✅ Verification successful
Significant change: Default configuration now uses mainnet instead of testnet
This changes the default configuration from
PlatformConfig::default_testnet()toPlatformConfig::default_mainnet(), which represents a shift from using test environment defaults to production environment defaults when no config is provided.Verify that this change is intentional and properly documented. Make sure consumers of this API are aware that the default behavior has changed, as it could affect any code that relies on the default configuration.
🏁 Script executed:
#!/bin/bash # Check if there are any documentation updates or release notes mentioning this change rg --type md "default.*mainnet|testnet.*mainnet|mainnet.*default" -A 3 -B 3Length of output: 2092
Default configuration change verified as intentional
The update in
packages/rs-drive-abci/src/platform_types/platform/mod.rssetting the default to mainnet is intentional. This change is documented in the project’s changelog (e.g., the entry “sdk: change default network to mainnet ([#2161])”). Please ensure that all consumers of this API are aware of the update to avoid unexpected production behavior.packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/mod.rs (3)
10-11: Great use of feature flags for conditional compilation.
This ensures the test module is only included in builds with the “sdk-test-data” feature.
47-48: Error propagation looks good.
Using?completes the match expression cleanly and avoids boilerplate error handling.
49-55: Confirm “not(test)” build requirement.
This block is skipped during tests. If the code is intended for in-test usage too, you may want to removenot(test)or make it configurable.packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs (3)
35-39: IDs reuse is acceptable for testing.
No concerns here, given the acceptance of shared byte patterns across different identifier types in test scenarios.
152-263: Data contract creation appears consistent.
Groups, token configuration, and control rules look logically sound.
265-314: Minting logic looks correct.
The incremental token allocations across identities align with test needs.
| fn register_identities( | ||
| &self, | ||
| block_info: &BlockInfo, | ||
| transaction: TransactionArg, | ||
| platform_version: &PlatformVersion, | ||
| ) -> Result<(), Error> { | ||
| for id in [IDENTITY_ID_1, IDENTITY_ID_2, IDENTITY_ID_3] { | ||
| // Create identity without keys | ||
| let mut identity = Identity::create_basic_identity(id, platform_version)?; | ||
|
|
||
| // Generate keys | ||
| let seed = id.to_buffer()[0]; | ||
| let mut rng = StdRng::seed_from_u64(seed as u64); | ||
| let keys = IdentityPublicKey::main_keys_with_random_authentication_keys_with_private_keys_with_rng(3, &mut rng, platform_version)?; | ||
|
|
||
| for (key, private_key) in keys.iter() { | ||
| let private_key = hex::encode(private_key); | ||
|
|
||
| tracing::info!( | ||
| key = ?key, | ||
| private_key, | ||
| "Generated random {} key {} for test identity {}", key.purpose(), key.id(), id); | ||
| } | ||
|
|
||
| // Print private keys if necessary | ||
| identity.set_public_keys( | ||
| keys.into_iter() | ||
| .enumerate() | ||
| .map(|(i, (key, _private_key))| (i as KeyID, key)) | ||
| .collect(), | ||
| ); | ||
|
|
||
| self.drive.add_new_identity( | ||
| identity, | ||
| false, | ||
| block_info, | ||
| true, | ||
| transaction, | ||
| platform_version, | ||
| )?; | ||
| } | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
Avoid logging private keys in traces.
Even in test code, printing private keys can pose a security risk if logs are exposed.
- tracing::info!(
- key = ?key,
- private_key,
- "Generated random {} key {} for test identity {}", key.purpose(), key.id(), id);
+ // Avoid logging the private key to prevent accidental exposure
+ tracing::info!(
+ key = ?key,
+ "Generated random {} key {} for test identity {}", key.purpose(), key.id(), id);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| fn register_identities( | |
| &self, | |
| block_info: &BlockInfo, | |
| transaction: TransactionArg, | |
| platform_version: &PlatformVersion, | |
| ) -> Result<(), Error> { | |
| for id in [IDENTITY_ID_1, IDENTITY_ID_2, IDENTITY_ID_3] { | |
| // Create identity without keys | |
| let mut identity = Identity::create_basic_identity(id, platform_version)?; | |
| // Generate keys | |
| let seed = id.to_buffer()[0]; | |
| let mut rng = StdRng::seed_from_u64(seed as u64); | |
| let keys = IdentityPublicKey::main_keys_with_random_authentication_keys_with_private_keys_with_rng(3, &mut rng, platform_version)?; | |
| for (key, private_key) in keys.iter() { | |
| let private_key = hex::encode(private_key); | |
| tracing::info!( | |
| key = ?key, | |
| private_key, | |
| "Generated random {} key {} for test identity {}", key.purpose(), key.id(), id); | |
| } | |
| // Print private keys if necessary | |
| identity.set_public_keys( | |
| keys.into_iter() | |
| .enumerate() | |
| .map(|(i, (key, _private_key))| (i as KeyID, key)) | |
| .collect(), | |
| ); | |
| self.drive.add_new_identity( | |
| identity, | |
| false, | |
| block_info, | |
| true, | |
| transaction, | |
| platform_version, | |
| )?; | |
| } | |
| Ok(()) | |
| } | |
| fn register_identities( | |
| &self, | |
| block_info: &BlockInfo, | |
| transaction: TransactionArg, | |
| platform_version: &PlatformVersion, | |
| ) -> Result<(), Error> { | |
| for id in [IDENTITY_ID_1, IDENTITY_ID_2, IDENTITY_ID_3] { | |
| // Create identity without keys | |
| let mut identity = Identity::create_basic_identity(id, platform_version)?; | |
| // Generate keys | |
| let seed = id.to_buffer()[0]; | |
| let mut rng = StdRng::seed_from_u64(seed as u64); | |
| let keys = IdentityPublicKey::main_keys_with_random_authentication_keys_with_private_keys_with_rng(3, &mut rng, platform_version)?; | |
| for (key, private_key) in keys.iter() { | |
| let private_key = hex::encode(private_key); | |
| // Avoid logging the private key to prevent accidental exposure | |
| tracing::info!( | |
| key = ?key, | |
| "Generated random {} key {} for test identity {}", key.purpose(), key.id(), id); | |
| } | |
| // Print private keys if necessary | |
| identity.set_public_keys( | |
| keys.into_iter() | |
| .enumerate() | |
| .map(|(i, (key, _private_key))| (i as KeyID, key)) | |
| .collect(), | |
| ); | |
| self.drive.add_new_identity( | |
| identity, | |
| false, | |
| block_info, | |
| true, | |
| transaction, | |
| platform_version, | |
| )?; | |
| } | |
| Ok(()) | |
| } |
There was a problem hiding this comment.
It's only the way to pass them to a developer who intentionally enables it.
There was a problem hiding this comment.
@shumkov I understand - thanks for the clarification. Since this is intentional test code behavior that's only enabled when a developer explicitly chooses to enable it, the logging of private keys is acceptable in this context. I'll retract my suggestion.
✏️ Learnings added
Learnt from: shumkov
PR: dashpay/platform#2449
File: packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs:107-150
Timestamp: 2025-03-13T07:24:36.870Z
Learning: In the RS SDK test data generation code, logging private keys is intentional and only enabled when a developer explicitly chooses to enable it, which is acceptable in test code contexts.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (20)
Dockerfile (3)
405-408: Define SDK_TEST_DATA with a Default Value
While the comment explains that settingSDK_TEST_DATA=truecreates SDK test data on chain genesis, it might be clearer and safer to add a default value (for example,ARG SDK_TEST_DATA=false). This change helps prevent accidental inclusion of test data in production builds if the argument isn’t explicitly set.
428-434: Conditional Feature Flag Handling for SDK_TEST_DATA
The block conditionally appendingsdk-test-datatoFEATURES_FLAGis well documented. Ensure that this logic correctly integrates with any preexisting feature flags (e.g.--features=console,grovedbg) and covers all build scenarios.
496-502: Duplicate Handling of SDK_TEST_DATA in Build Command
A second similar conditional block appears later to conditionally append thesdk-test-dataflag. Consolidating this logic could reduce maintenance overhead and prevent potential inconsistencies. Consider refactoring if feasible (for example, by moving this conditional logic into a shared shell script segment).packages/rs-sdk/src/platform/tokens/token_info.rs (2)
12-19: Struct naming is clear; consider documenting edge cases.
DefiningIdentityTokenInfosQueryclarifies that it queries token info for a single identity. It might be helpful to document what happens iftoken_idsis empty or if the providedidentity_iddoes not exist.
70-70: Follow up on the TODO comment.
A TODO note in the code indicates the need to implementFetchor similar traits. Make sure to track it in an issue or handle it in a future commit.Do you want help generating the missing implementations or opening a task for it?
packages/rs-sdk/src/platform/group_actions.rs (1)
32-44: Group info request creation is correct.
Mapping the group contract position tou32is presumably safe, assuming no large values are expected. Otherwise, consider bounds checks.packages/rs-drive-proof-verifier/src/types/groups.rs (1)
7-14: Enhance documentation for type aliases.Currently, the doc comments for
Groups,GroupActions, andGroupActionSignersare very brief and may not provide enough context about the intended usage and semantics of these type aliases. Expanding the doc comments to clarify how these aliases fit into the overall group-related functionality (e.g., “Groups represents ... in the context of X, used for ...”) would improve readability and maintainability.packages/rs-drive-proof-verifier/src/proof/token_total_supply.rs (2)
31-36: Improve error message details for debugging.When the code fails to convert the token ID to
[u8; 32], consider including the expected and actual lengths or other contextual information in the error message. This will simplify debugging if the token ID is malformed.map_err(|_| Error::RequestError { - error: "can't convert token_id to [u8; 32]".to_string(), + error: format!( + "can't convert token_id to [u8; 32], received {} bytes", + v0.token_id.len() + ), })?
18-58: Consider adding negative test coverage.Since this is new functionality, ensure thorough test coverage. In particular, adding negative tests (e.g., malformed token ID, corrupted proof, missing metadata) will help confirm that the error handling paths behave as expected.
Would you like help creating a test suite to validate these edge cases?
packages/rs-drive-proof-verifier/src/proof/token_status.rs (2)
31-39: Improve the token IDs error message.Similar to the token total supply logic, when the code fails to convert the token IDs to
[u8; 32], providing extra context like the problematic ID length would be helpful for debugging.map_err(|_| Error::RequestError { - error: "can't convert token_ids to [u8; 32]".to_string(), + error: "can't convert one or more token_ids to [u8; 32], length mismatch".to_string(), })?
18-56: Add test coverage for edge cases.Since this file introduces a new
FromProofimplementation, consider adding tests to handle edge scenarios, such as invalid token ID vectors, missing proofs, etc., to validate that your error handling paths are triggered appropriately.packages/rs-drive-proof-verifier/src/types.rs (1)
8-12: Ensure public modules are necessary and consistent.
Exposing every module as public is fine if they're intended for consumption beyond this crate. Otherwise, consider whether all of them need public visibility.packages/rs-drive-proof-verifier/src/proof/identity_token_balance.rs (3)
32-50: Redundant error message strings.
In lines 35-36 and 45-46, the error messages about converting theidentity_idortoken_idto[u8; 32]are repetitive. To keep error logs uniform and easier to maintain, consider extracting a helper function or using a single consolidated error message.-Error::RequestError { - error: "can't convert identity_id to [u8; 32]".to_string(), -} +Error::RequestError { + error: "failed to parse identity_id, must be exactly 32 bytes".to_string(), +}
57-70: Double-check proof verification flow.
After verifying the proof withDrive::verify_token_balances_for_identity_id, the logic callsverify_tenderdash_proofnext. Ensure there is no scenario where a partial success in the first step leads to an overlooked verification detail in the second. It might be beneficial to unify or strictly order these verifications into a single guard function if the logic grows more complex.
74-84: Maintain consistent naming for multi-identity requests.
The function name, parameter naming, and returned type are consistent overall, but to enhance clarity, consider an explicit reference to the "multi-identity" or "bulk" concept in the doc comments or function signature. This helps future maintainers differentiate these from single-identity requests at a glance.packages/rs-drive-proof-verifier/src/error.rs (1)
1-1: Import clarity onResponseMetadatausage.
The code referencesResponseMetadataat the top level. Consider re-exporting or aliasing it if you expect more usage here, preventing confusion with other similarly named metadata structs.packages/rs-drive-proof-verifier/src/proof.rs (1)
59-59: Consider removing or replacing the debug print.
Usingprintln!might be a leftover debug statement. Replace it with a logging macro (e.g.,log::debug!) or remove it if no longer needed.- println!("{:?}", hex::encode(&proof.grovedb_proof)); + log::debug!("GroveDB proof: {:?}", hex::encode(&proof.grovedb_proof));packages/rs-drive-proof-verifier/src/proof/token_info.rs (1)
59-59: Consider removing or replacing the debug print.
Usingprintln!might be a leftover debug statement. Replace it with a logging macro or remove it if no longer needed.- println!("{:?}", hex::encode(&proof.grovedb_proof)); + log::debug!("GroveDB proof: {:?}", hex::encode(&proof.grovedb_proof));packages/rs-drive-proof-verifier/src/proof/groups.rs (1)
151-249: Consider reducing duplication across proof verification.
Noticing repetitive logic for contract ID parsing, status checks, and optional retrieval across these data structures. You could factor out common code (e.g., a helper utility or macro) to streamline and reduce potential divergence.packages/rs-sdk/src/mock/requests.rs (1)
288-300: Refactor repeated serialization/deserialization patterns.
The approach of cloning and collecting to a vector, then encoding/decoding, is repeated in subsequent mock responses (e.g., for token balances, token infos, group actions, etc.). Consider extracting this repeated pattern into a generic helper or macro to improve maintainability.- impl MockResponse for IdentityTokenBalances { - fn mock_serialize(&self, sdk: &MockDashPlatformSdk) -> Vec<u8> { - self.0.mock_serialize(sdk) - } - ... - } + // Example macro usage or helper function: + macro_rules! impl_retrieved_values_mock_response { + ($type_name:ty, $inner_type:ident) => { + impl MockResponse for $type_name { + fn mock_serialize(&self, sdk: &MockDashPlatformSdk) -> Vec<u8> { + self.0.mock_serialize(sdk) + } + fn mock_deserialize(sdk: &MockDashPlatformSdk, buf: &[u8]) -> Self { + let map = RetrievedValues::$inner_type::mock_deserialize(sdk, buf); + Self(map) + } + } + } + } + + // Then call: + // impl_retrieved_values_mock_response!(IdentityTokenBalances, <key, value type>):
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (26)
Dockerfile(5 hunks)packages/rs-drive-proof-verifier/src/error.rs(2 hunks)packages/rs-drive-proof-verifier/src/proof.rs(29 hunks)packages/rs-drive-proof-verifier/src/proof/groups.rs(1 hunks)packages/rs-drive-proof-verifier/src/proof/identity_token_balance.rs(1 hunks)packages/rs-drive-proof-verifier/src/proof/token_info.rs(1 hunks)packages/rs-drive-proof-verifier/src/proof/token_status.rs(1 hunks)packages/rs-drive-proof-verifier/src/proof/token_total_supply.rs(1 hunks)packages/rs-drive-proof-verifier/src/types.rs(1 hunks)packages/rs-drive-proof-verifier/src/types/groups.rs(1 hunks)packages/rs-drive-proof-verifier/src/types/identity_token_balance.rs(1 hunks)packages/rs-drive-proof-verifier/src/types/token_info.rs(1 hunks)packages/rs-drive-proof-verifier/src/types/token_status.rs(1 hunks)packages/rs-drive-proof-verifier/src/unproved.rs(1 hunks)packages/rs-drive/Cargo.toml(2 hunks)packages/rs-sdk/src/mock/requests.rs(6 hunks)packages/rs-sdk/src/platform/fetch_unproved.rs(1 hunks)packages/rs-sdk/src/platform/group_actions.rs(1 hunks)packages/rs-sdk/src/platform/tokens/identity_token_balances.rs(1 hunks)packages/rs-sdk/src/platform/tokens/token_info.rs(1 hunks)packages/rs-sdk/src/platform/tokens/token_status.rs(1 hunks)packages/rs-sdk/src/platform/types/evonode.rs(1 hunks)packages/rs-sdk/tests/fetch/document.rs(1 hunks)packages/rs-sdk/tests/fetch/evonode.rs(1 hunks)packages/rs-sdk/tests/fetch/tokens/identity_token_balances.rs(1 hunks)packages/rs-sdk/tests/fetch/tokens/token_info.rs(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- packages/rs-drive-proof-verifier/src/types/token_status.rs
- packages/rs-drive-proof-verifier/src/unproved.rs
- packages/rs-sdk/src/platform/fetch_unproved.rs
- packages/rs-sdk/src/platform/types/evonode.rs
- packages/rs-sdk/tests/fetch/evonode.rs
🚧 Files skipped from review as they are similar to previous changes (5)
- packages/rs-sdk/tests/fetch/tokens/identity_token_balances.rs
- packages/rs-sdk/src/platform/tokens/identity_token_balances.rs
- packages/rs-sdk/src/platform/tokens/token_status.rs
- packages/rs-sdk/tests/fetch/tokens/token_info.rs
- packages/rs-drive/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: Rust packages (rs-dapi-client) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Rust packages (dpp) / Tests
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dash-sdk) / Tests
- GitHub Check: Rust packages (dash-sdk) / Linting
- GitHub Check: Rust packages (dash-sdk) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (40)
Dockerfile (2)
21-22: Enhance SDK_TEST_DATA Documentation
The new documentation for theSDK_TEST_DATAargument is a good start. However, consider expanding it to clarify its intended use (i.e. strictly for local development/testing) and its default behavior when not provided.
760-760: Include token-history-contract in Final DAPI Image
The new COPY command to include thetoken-history-contractpackage in the final DAPI image is aligned with the SDK token and group queries feature implementation. Please verify that the package is correctly built in thebuild-dapistage and that the path remains valid.packages/rs-sdk/tests/fetch/document.rs (1)
137-137: Improved readability for document retrieval
Previously, the code used<Document>::fetch_many(&sdk, query). Changing it toDocument::fetch_many(&sdk, query)is functionally equivalent and helps readability. There are no further issues here.packages/rs-sdk/src/platform/tokens/token_info.rs (5)
21-35: Request construction logic seems sound.
The conversion of identifiers to byte vectors is straightforward, and including theproveflag aligns with similar patterns in the codebase. No immediate improvements needed.
37-39: FetchMany trait usage is consistent with the codebase.
The association ofGetIdentityTokenInfosRequestwithIdentityTokenInfois coherent.
41-48: Struct for querying multiple identities is well-defined.
IdentitiesTokenInfosQueryfocuses on many identities and one token. Everything looks correct.
50-67: Request construction pattern is consistent and robust.
Similar pattern as before, converting identifiers to vectors. Looks good.
72-73: Multi-identity fetch usage is consistent.
UsingFetchMany<Identifier, IdentitiesTokenInfos>forIdentityTokenInfois aligned with the code pattern.packages/rs-sdk/src/platform/group_actions.rs (10)
23-30: Clear struct for querying a single group.
GroupQuerysuccinctly captures the essentials for a single group fetch (contract ID and position). This is well-defined.
46-48:Fetchtrait forGroupis straightforward.
Nothing to refine here.
50-61: Struct for multiple groups is well-structured.
start_group_contract_positionandlimitare optional, which is helpful for partial queries.
63-83: Multiple group info request logic is consistent.
Similar pattern of converting fields and respecting the prove flag. Looks good.
85-87: Adequate usage ofFetchManyfor multiple groups.
No issues identified.
89-104: Struct for group actions queries is comprehensive.
Including action status, starting action ID, and a limit is a good approach.
106-128: Group actions request creation is well-handled.
Multiple fields (group_contract_position,status,start_at_action_id) are converted properly. The approach is consistent and clear.
130-132: Fetching multiple group actions is straightforward.
No changes suggested.
134-145: Helpful struct for group action signers.
Captures necessary attributes—contract ID, position, status, etc. Nicely done.
147-167: Query creation and trait implementation wrap up scope neatly.
Request logic is consistent, handling proofs and conversion. Looks good.packages/rs-drive-proof-verifier/src/proof/token_total_supply.rs (1)
45-51:✅ Verification successful
Confirm the
falseparameter usage in verification.The boolean parameter passed to
Drive::verify_token_total_supply_and_aggregated_identity_balanceis hard-coded asfalse. Verify that this accurately reflects the intended behavior for the total supply verification process.Can you confirm from the broader codebase context that passing
falseis correct? If unsure, please run a usage search script like:
🏁 Script executed:
#!/bin/bash # Searches for all references to verify_token_total_supply_and_aggregated_identity_balance in the codebase fd verify_token_total_supply_and_aggregated_identity_balance --exec rg -A 5 'verify_token_total_supply_and_aggregated_identity_balance'Length of output: 3888
Parameter Usage Confirmed
After reviewing the function signature and its references, passing
falseis correct. The parameter corresponds to theverify_subset_of_proofflag, and for total supply verification, the intent is to operate on the full proof rather than on a subset.
- The function signature in
packages/rs-drive/src/verify/tokens/verify_token_total_supply_and_aggregated_identity_balance/mod.rsclearly expects a boolean flag to determine whether to verify a subset of the proof.- The current usage in
packages/rs-drive-proof-verifier/src/proof/token_total_supply.rspassesfalse, which aligns with the intended behavior.packages/rs-drive-proof-verifier/src/proof/token_status.rs (1)
49-51:✅ Verification successful
Verify the
falseparameter usage inverify_token_statuses.Ensure the
falseparameter passed here corresponds to the intended verification mode for token statuses. If the logic changes in the future, you might switch this to a parameter or constant to increase clarity.If needed, run a usage search script:
🏁 Script executed:
#!/bin/bash fd verify_token_statuses --exec rg -A 5 'verify_token_statuses'Length of output: 2690
Clarification on the
falseParameter forverify_token_statusesThe value
falseis correctly being used for theverify_subset_of_proofparameter as intended. It signals that full proof verification is desired rather than a subset check. While this literal value works fine today, consider refactoring it into a named constant (or parameter) to boost clarity and guard against potential logic changes in the future.packages/rs-drive-proof-verifier/src/proof/identity_token_balance.rs (2)
15-26: Verify consistent error reporting for version checks.
The code properly returns an error whenrequest.versionis missing. Ensure future expansions (e.g., additional version variants) have the same rigor in error handling to avoid silent failures.
91-110: Gracefully handle empty identity_id list.
Whenv0.identity_idsis empty, the function eventually returns an empty vector of balances. Confirm that this is the intended behavior or if a validation error should be thrown.packages/rs-drive-proof-verifier/src/error.rs (2)
141-143: Encourage public reusability if needed.
The traitMapGroveDbErroris markedpub(crate), limiting its scope. If you plan to reuse it in external crates, consider making it fully public. Otherwise, this current visibility is appropriate for internal usage only.
145-160: Robust error mapping structure.
This error mapping consolidates GroveDB errors into a single call-site. Good approach for clarity and testability.packages/rs-drive-proof-verifier/src/proof.rs (3)
1-6: No issues with new module declarations.
These module exports appear to be aligned with the added features for groups, token status, etc.
54-57: New imports for group functionality look appropriate.
No concerns regarding these added imports.
286-286: Consistent usage of.map_drive_error(&proof, &mtd)
All these lines correctly handle DriveErrors, mapping them into higher-level errors with additional context. This approach is consistent and clear.Also applies to: 334-334, 399-399, 525-525, 628-628, 677-677, 723-723, 770-770, 887-887, 946-946, 1031-1031, 1078-1079, 1236-1236, 1318-1318, 1359-1359, 1401-1401, 1453-1453, 1497-1497, 1540-1540, 1584-1584, 1682-1682, 1727-1727, 1789-1789
packages/rs-drive-proof-verifier/src/types/token_info.rs (1)
1-52: Structures for managing token information look good.
Implementation details, includingDerefandFromIterator, are straightforward and likely to be easy to maintain.packages/rs-drive-proof-verifier/src/types/identity_token_balance.rs (1)
1-53: New types for identity token balances are well-defined.
DerefandFromIteratormake these structures flexible for aggregation and iteration.packages/rs-drive-proof-verifier/src/proof/token_info.rs (2)
15-74: Implementation ofFromProofforGetIdentityTokenInfosRequestappears correct.
Logic for extracting request parameters, verifying proofs, and returning results is cohesive and consistent.
76-134:FromProofforGetIdentitiesTokenInfosRequestis well-structured.
The method follows the same verification pattern and is consistent with the rest of the proof verification logic.packages/rs-drive-proof-verifier/src/proof/groups.rs (2)
77-149: Looks good!
This implementation is clear, handles optional retrieval gracefully, and extends the logic consistently.
251-327: Implementation aligns well with existing proof structures.
No critical issues noted, and the error handling is consistent with the rest of the file.packages/rs-sdk/src/mock/requests.rs (7)
302-314: Same logic here.
316-338: Same logic here.
340-362: Same logic here.
364-386: Same logic here.
388-401: Same logic here.
403-425: Same logic here.
448-448: No issues found.
This macro usage appears consistent with the rest of the file.
| let (root_hash, result) = Drive::verify_token_balances_for_identity_ids( | ||
| &proof.grovedb_proof, | ||
| token_id, | ||
| &identity_ids, | ||
| false, | ||
| platform_version, | ||
| ) | ||
| .map_drive_error(&proof, &metadata)?; | ||
|
|
||
| verify_tenderdash_proof(&proof, &metadata, &root_hash, provider)?; | ||
|
|
||
| Ok((Some(result), metadata, proof)) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Leverage shared logic for verification of identity IDs.
Similar to the single-identity version, verify both the root hash and the tenderdash proof. Consider extracting a helper method to avoid duplication in verifying the proof across multiple identity IDs.
| impl FromProof<GetGroupInfoRequest> for Group { | ||
| type Request = GetGroupInfoRequest; | ||
| type Response = GetGroupInfoResponse; | ||
|
|
||
| fn maybe_from_proof_with_metadata<'a, I: Into<Self::Request>, O: Into<Self::Response>>( | ||
| request: I, | ||
| response: O, | ||
| _network: Network, | ||
| platform_version: &PlatformVersion, | ||
| provider: &'a dyn ContextProvider, | ||
| ) -> Result<(Option<Self>, ResponseMetadata, Proof), Error> | ||
| where | ||
| Self: Sized + 'a, | ||
| { | ||
| let request: Self::Request = request.into(); | ||
| let response: Self::Response = response.into(); | ||
|
|
||
| let (contract_id, group_contract_position) = match request | ||
| .version | ||
| .ok_or(Error::EmptyVersion)? | ||
| { | ||
| get_group_info_request::Version::V0(v0) => { | ||
| let contract_id = | ||
| Identifier::try_from(v0.contract_id).map_err(|error| Error::RequestError { | ||
| error: format!("can't convert contract_id to identifier: {error}"), | ||
| })?; | ||
|
|
||
| let group_contract_position = v0.group_contract_position as GroupContractPosition; | ||
|
|
||
| (contract_id, group_contract_position) | ||
| } | ||
| }; | ||
|
|
||
| let metadata = response | ||
| .metadata() | ||
| .or(Err(Error::EmptyResponseMetadata))? | ||
| .clone(); | ||
|
|
||
| let proof = response.proof_owned().or(Err(Error::NoProofInResult))?; | ||
|
|
||
| let (root_hash, result) = Drive::verify_group_info( | ||
| &proof.grovedb_proof, | ||
| contract_id, | ||
| group_contract_position, | ||
| false, | ||
| platform_version, | ||
| ) | ||
| .map_drive_error(&proof, &metadata)?; | ||
|
|
||
| verify_tenderdash_proof(&proof, &metadata, &root_hash, provider)?; | ||
|
|
||
| Ok((result, metadata, proof)) | ||
| } | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Ensure coverage for invalid contract IDs.
Consider adding or verifying unit tests that confirm the behavior when contract IDs cannot be converted to identifiers. This will help catch or prevent regressions related to malformed IDs.
🏁 Script executed:
#!/bin/bash
# Description: Search for tests covering invalid contract IDs in `maybe_from_proof_with_metadata` calls
fd --type f test | xargs rg -A 5 "maybe_from_proof_with_metadata" | rg "invalid|error"Length of output: 86
Enhance test coverage for invalid contract IDs conversion
It appears that no unit tests currently validate the behavior of maybe_from_proof_with_metadata when Identifier::try_from fails (e.g. when an invalid contract ID is provided). Please add tests to simulate this failure scenario and verify that the function returns the expected Error::RequestError. In particular, ensure that the failure message ("can't convert contract_id to identifier: {error}") is correctly produced.
- Location:
packages/rs-drive-proof-verifier/src/proof/groups.rs(lines 22–75)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Non-standard JSON Format is IntentionalThis file is a test vector containing a raw hash value rather than a strictly formatted JSON string. The static analysis error (string values must be double quoted) is a false positive here, as the unconventional format is acceptable within our testing framework.
It might be helpful to add an inline comment in the file clarifying that this non-standard format is intentional.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector File AcceptableThis JSON file, used for token total supply testing, deliberately contains a raw hash value without the normal JSON quotes. The deviation from standard JSON is intentional within the project's test vectors, and the static analysis hint can be safely disregarded.
Adding a brief comment in the file to document this intentional deviation could be useful for future maintainers.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Non-Standard Format for Test VectorsThis file provides a test vector for multiple identities token balances with an intentionally unquoted hash value. The unconventional formatting is compliant with our project’s testing framework and the static analysis error is a false positive in this context.
Consider adding a short comment to note the intentional non-standard format.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Valid Test Vector for Document Read ScenariosThis new test vector file is used in scenarios where no contract is present, and it intentionally contains a bare hash value. The file’s non-standard JSON formatting is acceptable, and the reported static analysis warning is a false positive.
For clarity, you may wish to add an inline comment in this file explaining the deliberate deviation from standard JSON.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Appropriate Test Vector FormatThis file, which serves as a test vector for protocol version votes where no votes are present, also contains a raw hash value. The lack of double quotes is intentional and aligns with the testing strategy; hence, the static analysis error is not a concern.
An inline note within the file explaining that this format is by design could further aid maintainability.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/dapi/lib/grpcServer/handlers/platform/getStatusHandlerFactory.js (1)
167-189: Consider updating remaining numeric conversions for consistencyWhile the changes to use
toString()for block heights and sync metrics are appropriate, there are still other places in the file usingNumber()(lines 105, 108, 181, 203). For full consistency, consider standardizing the approach across all similar numeric values.- versionProtocolTenderdash.setBlock( - Number(tenderdashStatus.node_info.protocol_version.block), - ); + versionProtocolTenderdash.setBlock( + tenderdashStatus.node_info.protocol_version.block.toString(), + ); - versionProtocolTenderdash.setP2p( - Number(tenderdashStatus.node_info.protocol_version.p2p), - ); + versionProtocolTenderdash.setP2p( + tenderdashStatus.node_info.protocol_version.p2p.toString(), + ); - stateSync.setTotalSnapshots(Number(tenderdashStatus.sync_info.total_snapshots)); + stateSync.setTotalSnapshots(tenderdashStatus.sync_info.total_snapshots.toString()); - network.setPeersCount(Number(tenderdashNetInfo.n_peers)); + network.setPeersCount(tenderdashNetInfo.n_peers.toString());
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (46)
packages/dapi/lib/grpcServer/handlers/platform/getStatusHandlerFactory.js(1 hunks)packages/rs-sdk/src/core/dash_core_client.rs(1 hunks)packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/data_contract-e668c659af66aee1e72c186dde7b5b7e0a1d712a09c40d5721f622bf53c53155.json(1 hunks)packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_1_groups_since_0/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_all_group_actions/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_all_groups_since_1_inclusive/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_group_action_signers/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_one_group_action_since_existing_one_with_limit/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_group_fetch/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_group_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_identities_token_infos/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_identities_unknown_token_infos/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json(1 hunks)
🧰 Additional context used
🧠 Learnings (43)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_1_groups_since_0/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_all_group_actions/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_all_groups_since_1_inclusive/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_group_action_signers/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_one_group_action_since_existing_one_with_limit/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_group_fetch/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_group_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identities_token_infos/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identities_unknown_token_infos/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
🪛 Biome (1.9.4)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_1_groups_since_0/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_all_group_actions/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_all_groups_since_1_inclusive/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_group_action_signers/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_one_group_action_since_existing_one_with_limit/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_group_fetch/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_group_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identities_token_infos/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identities_unknown_token_infos/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json
[error] 1-1: String values must be double quoted.
(parse)
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (rs-dapi-client) / Unused dependencies
- GitHub Check: Rust packages (rs-dapi-client) / Tests
- GitHub Check: Rust packages (rs-dapi-client) / Linting
- GitHub Check: Rust packages (rs-dapi-client) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Formatting
- GitHub Check: Rust packages (dpp) / Unused dependencies
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dash-sdk) / Tests
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (45)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/data_contract-e668c659af66aee1e72c186dde7b5b7e0a1d712a09c40d5721f622bf53c53155.json (3)
1-1: JSON Format Version UpdateThe file's top-level
$format_versionhas been updated to"1". Please verify that all modules or tests consuming this file properly handle the new version.
1-1: Configuration Update:sizedIntegerTypesThe
"config"section now includes a new key"sizedIntegerTypes": true. Confirm that downstream functionality interprets this setting correctly and that corresponding documentation is updated.
1-1: New Fields Added:groupsandtokensEmpty objects
"groups": {}and"tokens": {}have been introduced at the root level to support token and group query features. Ensure that any code relying on these fields is updated to accommodate these changes, and verify that future test vectors or SDK functions utilize these fields as intended.packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Test Vector Format for Identity Contract No Nonce ReadThis file contains a raw hash value used as a test vector. Although the content is not wrapped in quotes and lacks a newline—as noted by the static analysis—it follows the intentional, non-standard JSON style accepted within our testing framework based on previous learnings.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Accepted Test Data Format for Data Contracts 2 NXThe new test vector file uses a similar format to other test files by including a single hash value without any additional JSON structure. The absence of double quotes is intentional for these mocks, so the static analysis warning can be safely ignored.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector for Epoch List LimitThis file includes a single hash value designated for testing the epoch list limit scenario. The file intentionally does not adhere to strict JSON formatting, which is consistent with our approved testing strategy. The static analysis hint regarding double quotes is not applicable in this context.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector for Document Read No DocumentThis file provides a raw hash as a test vector for the “no document” scenario. Its minimalistic format—including the intentional omission of a trailing newline and non-quotation of the string—is by design for our testing purposes. The static analysis error can be disregarded given our project's accepted mock data format.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_1_groups_since_0/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Valid Test Vector for Fetching Groups Since 0This new file is a test vector used to validate the fetch of group queries. The file contains a single hash line following the intentional format used for similar test vectors in our project. The static analysis warning regarding missing double quotes is a false positive in this context.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Non-Standard JSON Format for Test Vector
This file contains a single raw hash value without double quotes. Although not valid JSON per the strict spec, this format is intentionally used for test vectors in this project. The static analysis error about double quotes can be safely ignored here.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Non-Standard JSON Format for Test Vector
Similar to other test vector files, this file intentionally contains a raw hash value without double quotes. This format is acceptable within the testing framework, and the static analysis warning does not apply in this context.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_group_action_signers/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Non-Standard JSON Format for Test Vector
This file, used for testing group action signers, follows a non-standard JSON structure by including a single hash value without double quotes. This is an intentional decision for test data, so the static analysis error regarding string quoting can be disregarded.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_all_groups_since_1_inclusive/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Non-Standard JSON Format for Test Vector
This test file intentionally uses a non-standard JSON format (a raw hash value without double quotes) to serve as a test vector. The static analysis warning about quoting is a false positive in this scenario.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Non-Standard JSON Format for Test Vector
This new JSON file, used for testing identity public keys, deliberately contains only a single hash value without double quotes. This non-standard format is by design for test vector purposes and is acceptable despite the static analysis warning regarding string quoting.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Non-Standard JSON Format for Test VectorThe file contains a single hash value without standard JSON quoting or structure. This is intentional for the testing framework and complies with the project's established approach. The static analysis warning about string quoting can be safely ignored in this context. Consider adding a newline at the end if your environment requires it.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Valid Test Vector Format for Identity Token BalancesThis new file adds a single hash as a test vector. The format intentionally deviates from standard JSON (e.g., not double quoting string values) per the project's testing conventions. The static analysis error is a false positive here.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Appropriate Format for Negative Test ScenarioThis file contains a single hash used in a "not found" scenario. The absence of conventional JSON formatting (e.g., lack of double quotes) is deliberate for test vector purposes. The static analysis hint regarding double quotes is not applicable in this controlled test context. If necessary, consider appending a newline, but otherwise the file is acceptable.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Consistent Test Vector ContentHere again, a single hash value is used to simulate a "data contract read not found" scenario. The file intentionally does not adhere to standard JSON formatting. The static analysis warning is a false positive in light of the testing requirements.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_one_group_action_since_existing_one_with_limit/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Proper Test Vector for Group Action QueryThis file adds a test vector for group action queries by including a single hash. As per the project's testing framework, the unconventional JSON structure is intentional, and the static analysis flag about double quoting is not applicable. Consider a trailing newline if it’s required by your text editor standards.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Non-Standard JSON Format is IntentionalThe file contains a single hash value without double quotes. Although the static analysis tool flags this with a "String values must be double quoted" error, this non-standard format is intentional for test vectors in this project.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Minimalistic Test DataThis JSON file also contains a single hash value without quotes and does not include a newline at the end. The non-standard JSON formatting is in line with the project’s testing framework where such mock data files are used intentionally.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Consistent Test Vector FormatThis file follows the same pattern as the others: a single hash value presented without double quotes and lacking a newline at the end. The static analysis warning can be safely disregarded as the file intentionally uses a minimalistic, non-standard JSON format for testing purposes.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Appropriate Test Data UsageThis file, containing only a hash value without standard JSON quoting and missing a trailing newline, is acceptable as a test vector. The static analysis warning regarding double quoted strings is a known false positive in this context.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_group_fetch/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector for Group Fetch is ValidLike the other test vectors, this file is intentionally structured as a single-line hash without double quotes and without a trailing newline. The static analysis message is not applicable in this case.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector Format – Token Status
This file contains a single hash value used as a test vector. The intentionally minimal content, absence of additional JSON structure, and the missing newline are acceptable under our testing framework. The static analysis warning regarding double quotes is a false positive in this context.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector Format – Identity Read By Key
The file provides a hash value for identity read-by-key test vectors. Its format, which deviates from standard JSON (e.g., no double quotes and missing terminal newline), is intentional for our testing purposes. The static analysis error can be disregarded.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector Format – Epoch Fetch
This file’s single-line hash serves as a test vector for epoch fetch functionality. The unconventional JSON formatting (lack of quoting and trailing newline) is deliberate and consistent with similar test files. The Biome static analysis warning is not applicable here.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector Format – Epoch Fetch Future
The file contains only a hash value meant for future epoch fetch test scenarios. Its minimalist format, including the lack of typical JSON quoting and absence of a newline, is intentional. The static analysis error regarding string quoting should be ignored.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector Format – Epoch Fetch Current
This file, featuring a lone hash string, is designed as a test vector for current epoch fetch scenarios. Its departure from standard JSON (e.g., unquoted string and no ending newline) is by design according to our testing conventions. The static analysis complaint is a false positive in this context.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identities_token_infos/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Non-Standard JSON for Test Data
The file contains a single unquoted hash value. As per project guidelines for test vector files, non-standard JSON formatting (including lack of double quoting and a trailing newline) is acceptable.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Accepted Format for Protocol Version Votes Test Vector
This file intentionally presents a single hash value without standard JSON quoting. The static analysis warning ("String values must be double quoted") is a known false-positive in this testing context.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_all_group_actions/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector Format is Intentional
The file’s content—a single unquoted hash line—is designed as mock data for group action testing. The non-standard JSON format is intentional and acceptable under our testing framework.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Valid Test Vector for Contested Resource Vote States
This file is a test vector containing a single hash value without standard JSON formatting. Given the project's intentional design for such mock data, the static analysis warning can safely be ignored.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector for Identity Read is Acceptable
The file presents an unquoted hash value, which is in line with our intended approach for test mock data. The static analysis message regarding double quoting is a false positive in this context.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Test Vector FormatThis file is deliberately a minimal JSON test vector containing a single hash value. The missing newline and non-standard JSON formatting (i.e. the absence of double quotes) are acceptable per the project's testing framework. The static analysis error can be safely ignored in this context.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_group_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Intentional Format for Group Not Found TestThis file is intentionally formatted as a test vector with a single hash value, following the project's guidelines. The static analysis hint regarding double quoted string values is a false positive and does not impact the test data.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Deliberate Minimal JSON Test VectorThis test vector contains only a hash value and omits extra structure, which is intentional for this type of test scenario. The static analysis warning about string quotes is a known false positive in our testing context.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector for Identity Balance ReadThis file is added intentionally as a test vector and contains only a single hash value. The non-standard JSON formatting (absence of double quotes and newline) is acceptable per our project's testing strategy. The static analysis error is a false positive.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Vector for Identity Balance Revision ReadThe file is purposefully a minimal test vector containing a single hash value, and its format (e.g. missing a newline and using non-standard quoting) is intentional. The static analysis report regarding double quoting is not relevant here.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Note on Test Vector Formatting:
The file contains a single hash string without quotes or a trailing newline. Although static analysis flags that string values must be double-quoted, this deviation from standard JSON form is intentional for test vectors in this project.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identities_unknown_token_infos/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Test Fixture Acceptability Confirmation:
This file, used as a test vector for unknown token information, contains a lone hash value. Although it doesn’t conform to strict JSON standards (i.e. missing double quotes), this non-standard format is expected and acceptable for these mock data files.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1c409c20f1f7c2738dbffaa868286a2b9c4e45241e64a1f2b2fd28e2e19b86e1.json (1)
1-1: Conformance for Intentional Non-Standard Test Data:
This file represents a test vector for contested resource identity votes not found. The single-line hash and its lack of quotes or a trailing newline reflect an intentional design for these tests. The static analysis error regarding double quoting is a known false positive in this context.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/dapi/lib/grpcServer/handlers/platform/getStatusHandlerFactory.js (3)
167-171: Consistent type handling for block height valuesThe change from
Number()totoString()for block height values improves handling of large integers that might exceed JavaScript's safe integer limit. This adjustment ensures that block heights maintain their precision when represented in the API response.
179-189: Consistent string representation for sync metricsConverting all sync metrics to strings provides a uniform way to represent potentially large numeric values without precision loss. This change aligns well with the block height conversions and ensures consistent data types throughout the state sync information.
167-188:✅ Verification successful
Verify client compatibility with string type changes
Ensure that all clients consuming this API are prepared to handle these fields as strings rather than numbers. This type change might require updates to client-side parsing logic if clients were expecting numeric types.
🏁 Script executed:
#!/bin/bash # Search for references to the affected getter methods to identify potential compatibility issues echo "Searching for references to getLatestBlockHeight and other changed methods..." rg -i "(getLatestBlockHeight|getEarliestBlockHeight|getMaxPeerBlockHeight|getTotalSyncedTime|getRemainingTime|getChunkProcessAvgTime|getSnapshotHeight|getSnapshotChunksCount|getBackfilledBlocks|getBackfillBlocksTotal)" --type jsLength of output: 12119
Client Compatibility Verified
After reviewing the references in both the unit tests and client implementations (e.g., in the packages/js-dapi-client and packages/dapi-grpc directories), it is clear that all clients consuming these fields are already converting the string values using constructs like
BigInt(). This ensures that the API changes from numeric types to string representations are properly handled. No additional modifications are required on the client side.packages/rs-sdk/src/core/dash_core_client.rs (1)
136-136:❓ Verification inconclusive
Method updated from get_quorum_info to get_quorum_info_reversed
The change appears to be using a different method to retrieve quorum information, potentially affecting how quorum data is processed. This seems to be an intentional change to support the new token and group query functionality.
🏁 Script executed:
#!/bin/bash # Verify if the get_quorum_info_reversed method exists in the dashcore_rpc crate # and check how it differs from get_quorum_info # Look for method definitions in the RpcApi trait rg -A 3 "fn get_quorum_info" --type rust rg -A 3 "fn get_quorum_info_reversed" --type rustLength of output: 607
Action Required: Confirm the Existence and Integration of
get_quorum_info_reversed
The updated code usesget_quorum_info_reversedto support the new token and group query functionality. However, our initial search in the codebase did not reveal a definition for this method in the expected RPC trait (it was found forget_quorum_infoonly). Please verify that:
- The
get_quorum_info_reversedmethod exists (possibly defined elsewhere or introduced via a dependency update) and that its implementation correctly supports the intended changes.- The integration in
packages/rs-sdk/src/core/dash_core_client.rs(line 136) aligns with the new functionality without unintended side effects.
🏁 Script executed:
#!/bin/bash # Re-search for any definition of get_quorum_info_reversed in the repository rg -i "fn\s\+get_quorum_info_reversed" -t rustLength of output: 48
Action Required: Verify the Implementation of
get_quorum_info_reversedThe code in
packages/rs-sdk/src/core/dash_core_client.rs(line 136) now uses.get_quorum_info_reversed(...), replacing the originalget_quorum_infocall. However, our repository-wide search did not find any definition forget_quorum_info_reversed. Please verify that:
- The
get_quorum_info_reversedmethod is implemented—either in an updated version of the dependency (e.g., thedashcore_rpccrate) or elsewhere in the codebase.- Its behavior aligns with the new token and group query functionality and does not introduce regressions.
If this method is sourced from an external update or conditionally defined, updating documentation or adding tests to confirm its behavior would be beneficial.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (9)
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector Formatting – Epoch FetchThis file, used for the epoch fetch test vector, contains the same hash value and similarly does not enforce standard JSON formatting (i.e. missing double quotes). Note that it does not include a newline at the end; while this is generally recommended for text files, it appears to be consistent with the current test vector style. Confirm that this is intentional.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector Formatting – Token StatusThis newly added file is another test vector file containing a hash value. The static analysis warning regarding double quotes does not apply here since these mock data files are intentionally minimal and might not conform to valid JSON syntax. Also, note the absence of a trailing newline; please verify that this omission is as intended.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector Formatting – Epoch Fetch FutureThis file, intended as a test vector for future epoch fetch scenarios, follows the same pattern by providing a single hash value without standard JSON quoting and lacking a trailing newline. Since this is consistent with the project's intentional design for test vectors, the static analysis warning can be disregarded.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector Formatting – Token Total SupplyThis new file provides a hash value used as a test vector for verifying the token total supply functionality. As with the other test vector files, it does not comply with standard JSON formatting (e.g. missing double quotes) and omits the final newline. Given that these files serve a mock data role and are governed by the project's testing conventions, these issues are acceptable if they match the intended design.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Test Vector FormatThis new file contains a single hash value used as a test vector. Although the value is not enclosed in double quotes and the file lacks a trailing newline, this non-standard formatting is intentional given the project's practices for mock test data. Please verify that all consumers of these vectors are aware of and can handle this format.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Format for Contestation Test VectorThis file supplies a hash value used for tests involving contested resource identity votes. Its format—missing double quotes and a trailing newline—is intentional as per the project’s testing framework guidelines. Please ensure that any tooling or parsers processing these files correctly handle this non-standard format.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-drive/tests/supporting_files/contract/tokens/token-example-contract.json (1)
6-6: Empty "documentSchemas" Field.
The inclusion of"documentSchemas": {}might be a placeholder for future schema definitions. Consider adding documentation or a TODO comment for maintainers if schema validations or definitions are expected to be implemented later.packages/rs-sdk/tests/vectors/test_identities_unknown_token_infos/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Fixture File Format Notice:
This file contains a single raw hash value without any JSON structure (e.g. no double quotes around the string). As learned from previous similar test fixtures in our repository, this non-standard formatting is intentional and acceptable within our testing framework.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Fixture File Validity Confirmed:
This file serves as a mock fixture for contested resource vote states and, like other files in this directory, contains only a single hash value. Although the static analysis tool flags this as an error due to the absence of double quotes, the current format is deliberate and aligns with our project's established testing patterns.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (45)
packages/rs-drive/tests/supporting_files/contract/tokens/token-example-contract.json(1 hunks)packages/rs-sdk/Cargo.toml(2 hunks)packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_1_groups_since_0/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_all_group_actions/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_all_groups_since_1_inclusive/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_group_action_signers/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_fetch_one_group_action_since_existing_one_with_limit/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_group_fetch/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_group_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_identities_token_infos/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_identities_unknown_token_infos/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/rs-sdk/Cargo.toml
🧰 Additional context used
🧠 Learnings (43)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_1_groups_since_0/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_all_group_actions/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_all_groups_since_1_inclusive/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_group_action_signers/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_fetch_one_group_action_since_existing_one_with_limit/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_group_fetch/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_group_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identities_token_infos/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identities_unknown_token_infos/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2025-03-12T17:49:19.133Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.
🪛 Biome (1.9.4)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_1_groups_since_0/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_all_group_actions/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_all_groups_since_1_inclusive/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_group_action_signers/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_one_group_action_since_existing_one_with_limit/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_group_fetch/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_group_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identities_token_infos/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identities_unknown_token_infos/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json
[error] 1-1: String values must be double quoted.
(parse)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (40)
packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector Formatting – Multiple Identities Token BalancesThis file contains a single-line hash used as a test vector. Although the static analysis tool flags the string for not being double quoted (and hence not valid JSON), this deviation is intentional according to the project’s testing framework guidelines. If this behavior is acceptable within the mock data context, you can safely disregard the error.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector Format and Newline OmissionThis file contains a single hash value without a trailing newline. The lack of standard JSON formatting (e.g. missing double quotes) is intentional for our test vectors as per the project's established guidelines.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_1_groups_since_0/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Consistent Test Vector Mock DataThe file adds a hash value exactly as intended, and the absence of a trailing newline is acceptable. The static analysis message regarding string quoting can be safely disregarded in this testing context.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Validation of Document Read Test Data FormatThe new file is used for document read tests and contains a single hash value. The intentional omission of standard JSON formatting elements (e.g. double quotes and a trailing newline) is acceptable as per the testing framework’s design.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Identity Public Keys Test Data ReviewThis added JSON file provides a hash value in the expected test vector format. The deviation from strict JSON formatting is intentional for mock data purposes and is in line with our standards.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Drive Query Test Vector Format ConfirmationThe file contains a single hash value and follows the same intentional test vector style as other similar files. The Biome static analysis warning about string quoting is not applicable here given the deliberate design for mock data.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector Format – Intentional Non-Standard JSONThis file contains a single hash value without double quotes or a trailing newline. Such formatting is intentional as it aligns with our project's approach for mock data in test vectors. The static analysis error about double quoting is a false positive in this context.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector File for Document Read (No Contract) – Formatting ClarificationThis new file is used as a mock data source, containing a raw hash value. The lack of double quotes and newline is deliberate to match our testing framework’s expectations. The static analysis warning regarding string quoting can be safely disregarded.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_one_group_action_since_existing_one_with_limit/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector for Group Action Query – Acceptable Non-Standard JSONThe file adds a single-line hash value used as test data for group action queries. Its non-standard JSON structure (i.e. unquoted string and no newline) is intentional. The corresponding static analysis error is a false positive.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector for Data Contract Read-Not-Found – Formatting NoticeThis file contains solely a hash value serving as mock data for "read not found" scenarios. Its lack of quoting and trailing newline is by design as per our test data format. The static analysis complaint about double quotes is not applicable here.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_group_fetch/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector for Group Fetch – Confirmed Intentional FormatThis new test file also includes a raw hash value with no surrounding quotes or newline termination. It is consistent with our other mock data files used to simulate quorum public key data. The static analysis warning on string quoting is a false positive in this scenario.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_group_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Test Vector Format
This file introduces a new test vector containing a raw hash value without double quotes and without a trailing newline. The static analysis warning about string values not being double quoted is a known false positive here since these files are intentionally minimal mock data as established in our previous learnings.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Test Vector Format
The file adds a raw hash line used for testing unknown token balance scenarios. Although the static analysis tool flags the lack of double quotes, this format is deliberate for our test vectors. No changes are needed.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Test Vector Format
A new test vector file for epoch list tests is introduced, containing just a hash value. The file’s non-standard JSON style (no double quotes and no trailing newline) is intentional, matching our testing framework conventions.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Test Vector Format
This file is a new addition for identity balance read tests, containing a single hash string. The absence of double quotes and a newline is by design for our mock data files. The static analysis warning is therefore a non-issue.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Test Vector Format
This new JSON file, used for data contract read tests, adds a minimal test vector—a single line hash. Its format (raw hash without double quotes and lacking a trailing newline) follows our intentionally non-standard JSON approach for test vectors, so the static analysis message can be ignored.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Data File Format and Structure
This file contains a single hash value without additional formatting or a trailing newline. Although the static analysis tool flags a missing double-quote (suggesting that JSON strings must be double quoted), this non-standard format is intentional for mock test vector data per the project’s guidelines.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector Consistency Check
This file also holds a single hash string for testing purposes. Its minimalist format aligns with similar test vector files in the repository, and the static analysis warning can be safely ignored in this context.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Test Vector Format Validity
This file introduces a hash value in a deliberately simplified format. The static analysis error regarding double quotation is a false positive here, as these files are designed to be non-compliant with strict JSON syntax for testing reasons.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Identity Token Info Test Vector
This file, containing only a hash string, follows the intentional design for test vectors in the project. The absence of valid JSON formatting (such as double quotes and a trailing newline) is acceptable and consistent with other similar test fixtures in the repository.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Protocol Version Votes None Test Vector
This test vector file contains a single hash value without adhering to standard JSON syntactical rules. This format is entirely intentional for the purpose of testing various scenarios, and the static analysis warning regarding double-quoted strings is a known false positive in this context.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_all_groups_since_1_inclusive/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Mock Data FormattingThis file adds a hash value as a test vector without standard JSON quoting and a trailing newline. As with similar test files in the project, this format is deliberately chosen for testing purposes. Confirm that this format meets the expected input for your test harness.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Consistent Test Vector FormatThis newly added file, used in identity balance revision tests, provides a single hash value using the same non-standard JSON formatting as other test vectors (i.e., no double quotes and no trailing newline). This is acceptable per the project’s conventions. Just ensure that any JSON parsers or tools that process these vectors are configured to handle this custom format.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Deliberate Non-Standard JSON UsageThis file contains a single hash value intended for testing protocol version vote limits. The absence of double quotes around the string and the missing trailing newline are by design, following the established approach for mock data in the repository. The static analysis warning regarding string quoting can be safely disregarded in this context.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Non-standard JSON Format for Test VectorsThis file contains a single hash string without double quotes and without a trailing newline. Although the static analysis tool reports an error regarding string quoting, this format is acceptable and intentional for our mock test data.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Format for Document Read Test VectorThe single-line hash value is intentionally unquoted and lacks a trailing newline to meet the specific requirements of our test vector framework. The static analysis warning can be safely ignored.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Mock Data Format is on PurposeThis test vector file includes the raw hash string without double quotes. Despite the static analysis error, this non-standard JSON formatting is intentional for our test vectors. No changes are necessary.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Review of Epoch List Limit Test VectorThe file deliberately uses a raw hash string without double quoting and omits a newline at the end. This is intentional for consistency with our test framework, and the static analysis error can be disregarded.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_group_action_signers/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Group Action Signers Test Vector FormattingThis file follows the same intentional mock data pattern as our other test vectors: a single hash string without double quotes and no trailing newline. The static analysis warning about quoting is a false positive for this context.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Valid Test File Format for Test Vectors.
This file contains a single hash value intended as mock data for testing purposes. The static analysis error regarding unquoted string values is a known false positive, as these test vector files intentionally deviate from standard JSON formatting per project conventions.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_identities_token_infos/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Acceptable Mock Data Format.
Similar to other test vector files, this JSON file deliberately contains only a hash value without standard JSON quoting. The static analysis warning is a false positive in this context.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intended Test Vector Format.
This file is designed to serve as a test vector by containing only a hash value. The absence of double quotes around the value triggers a static analysis error, but this non-standard JSON format is intentional and acceptable for our testing framework.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_fetch_all_group_actions/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Proper Test Vector Usage for Group Actions.
This file, used for testing group actions, contains only a hash value. The static analysis complaint regarding the lack of double quotes is a known false positive since our mock data files purposely omit standard JSON structure.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Mock Data File Conforms to Project Testing Conventions.
This file is a newly added test vector containing a hash value for the "prefunded specialized balance not found" scenario. The static analysis error about double quoting is expected and can be safely ignored given our intentional design for test vector files.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1f0a25d463a2912cd31dd4f91b899a143d6ae990bb9bc89cb34f7c5db8b1b705.json (1)
1-1: Intentional Minimal JSON FormatThis file is an intentionally minimal test vector containing a single hash value. The static analysis warning about string quoting is a false positive in this context, as these files are expected to have a non-standard JSON format per the project's testing framework. Optionally, you could add a newline at the end for POSIX compliance, though it is not required.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: String values must be double quoted.
(parse)
packages/rs-drive/tests/supporting_files/contract/tokens/token-example-contract.json (5)
1-2: Top-Level Format Version Update.
The top-level"$format_version"has been updated from"0"to"1", indicating a major version change in the contract specification. Make sure that all downstream consumers and systems parsing this contract are aware of and are compatible with the new version.
8-20: Token Identifier and Conventions Structure.
The token is now keyed by"0"and includes a new"conventions"object that defines localization options (with"singularForm": "flurgon"and"pluralForm": "flurgons") and a"decimals"field. Please verify that using a numeric identifier ("0") instead of a literal token name is intentional, and ensure that the nested$format_versionwithin"conventions"(set to"0") is consistent with your versioning strategy for token metadata.
21-24: Supply Fields and Transferability Adjustments.
The previous fields ("initialSupply"and"maintainer") have been replaced with"baseSupply"and"maxSupply", and a new"keepsHistory"flag has been added. Confirm that these numerical values (baseSupply: 10000000000andmaxSupply: 50000000000) align with the intended economic and supply models, and that the removal of the old fields is fully accounted for in related business logic and validations.
25-59: Governance Rules Consistency.
The token contract now defines detailed governance rules for various token operations (freezeRules,unfreezeRules,destroyFrozenFundsRules, andemergencyActionRules), each under the version"V0". All rule sets share identical configurations for authorization and administrative actions. Please double-check that this uniformity is intentional and that it meets the updated regulatory and business requirements for token management.
1-64: Overall Structure and Integration.
The revamped token contract structure appears robust and aligns with the new RS SDK query requirements. Ensure that any changes are consistently reflected in the associated gRPC transport implementations, serialization traits, and functional tests across the SDK.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.cargo/config.toml (1)
26-28: Conditional Tokio Unstable Flag AdditionA new configuration block
[target.'cfg(all())']is added withrustflags = ["--cfg", "tokio_unstable"]. This centralizes the usage of the Tokio unstable flag rather than specifying it on individual target configurations. Please verify that removing the flag from the per-target sections is intentional and that this conditional application meets the build requirements for your token and group query features..cargo/config-test-sdk-data.toml (1)
26-27: Test SDK Conditional FlagsThe new
[target.'cfg(all())']block now adds two conditional flags:"--cfg", "tokio_unstable"and'--cfg', "create_sdk_test_data". This is a neat way to enable additional configuration only when all target conditions are met, particularly to support SDK test data generation. Ensure these flags do not conflict with production builds and that they are only activated when intended.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.cargo/config-test-sdk-data.toml(1 hunks).cargo/config.toml(2 hunks)Dockerfile(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: Rust packages (dash-sdk) / Formatting
- GitHub Check: Rust packages (dash-sdk) / Tests
- GitHub Check: Rust packages (dash-sdk) / Linting
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (rs-dapi-client) / Check each feature
- GitHub Check: Rust packages (rs-dapi-client) / Tests
- GitHub Check: Rust packages (rs-dapi-client) / Linting
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (5)
.cargo/config-test-sdk-data.toml (5)
1-3: AArch64 MUSL Target ConfigurationThe
[target.aarch64-unknown-linux-musl]section setsrustflagsto disable static CRT linking which is consistent with common cross-compilation practices. This configuration appears correct.
4-11: x86_64 MUSL Target ConfigurationThe
[target.x86_64-unknown-linux-musl]block correctly specifiesrustflagsfor disabling static linking as well as setting the target CPU. The formatting and values are consistent with the overall build configuration.
12-19: x86_64 GNU Target ConfigurationThe
[target.x86_64-unknown-linux-gnu]configuration similarly disables static linking and sets the target CPU. This is standard and aligns with expected build settings.
20-22: AArch64 GNU Target Linker ConfigurationThe
[target.aarch64-unknown-linux-gnu]block correctly specifies a custom linker (aarch64-linux-gnu-gcc), ensuring that the correct toolchain is used for linking.
23-25: WASM Target ConfigurationThe
[target.wasm32-unknown-unknown]section properly configures thegetrandom_backendfor WebAssembly builds usingrustflags. This is appropriate for targeting wasm environments.
github-project-automation
bot
moved this from In review / testing
to Done
in Platform team
chore: update to latest dash core 37 (#2483) feat(platform)!: token advanced distribution and updates (#2471) fix: token history contract (#2474) Co-authored-by: Ivan Shumkov <[email protected]> Co-authored-by: QuantumExplorer <[email protected]> fix(drive): using new rust dash core methods for reversed quorum hash to maintain backwards compatibility (#2489) feat: more granular integer document property types (#2455) Co-authored-by: Quantum Explorer <[email protected]> docs: update comment for data contract code range (#2476) feat: validate token name localizations (#2468) feat(sdk): get identity by non-unique keys build(deps): update grovedb to current develop test: test identity by non-unique pubkey hashes fix(sdk): dash core client fails to get quorum chore: minor fixes test(drive-abci): identity by non-unique pubkey start after chore: minor changes to verify feat(sdk): token and group queries (#2449) chore: revert limit 1 => limit none chore: add non-unique key to test identities test(sdk): test vectors for test_fetch_identity_by_non_unique_public_keys fix(platform)!: token distribution fixes and tests (#2494) chore(platform): bump to version 2.0.0-dev.1 (#2495) test: update assertion fix(sdk): make some things public (#2496) feat(platform): require token for document actions (#2498) fix: data contract proof doesn't work with new auto fields (#2501)
chore: update to latest dash core 37 (#2483) feat(platform)!: token advanced distribution and updates (#2471) fix: token history contract (#2474) Co-authored-by: Ivan Shumkov <[email protected]> Co-authored-by: QuantumExplorer <[email protected]> fix(drive): using new rust dash core methods for reversed quorum hash to maintain backwards compatibility (#2489) feat: more granular integer document property types (#2455) Co-authored-by: Quantum Explorer <[email protected]> docs: update comment for data contract code range (#2476) feat: validate token name localizations (#2468) feat(sdk): get identity by non-unique keys build(deps): update grovedb to current develop test: test identity by non-unique pubkey hashes fix(sdk): dash core client fails to get quorum chore: minor fixes test(drive-abci): identity by non-unique pubkey start after chore: minor changes to verify feat(sdk): token and group queries (#2449) chore: revert limit 1 => limit none chore: add non-unique key to test identities test(sdk): test vectors for test_fetch_identity_by_non_unique_public_keys fix(platform)!: token distribution fixes and tests (#2494) chore(platform): bump to version 2.0.0-dev.1 (#2495) test: update assertion fix(sdk): make some things public (#2496) feat(platform): require token for document actions (#2498) fix: data contract proof doesn't work with new auto fields (#2501)
Issue being fixed or feature implemented
We need to support token and group queries in RS SDK
What was done?
fixtures-and-mocksflag is enabled.How Has This Been Tested?
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
New Features
Improvements