Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 93.10% 92.72% -0.38%
==========================================
Files 23 23
Lines 3293 3355 +62
==========================================
+ Hits 3066 3111 +45
- Misses 227 244 +17 ☔ View full report in Codecov by Sentry. |
|
Is this affected, or even made easier, by scikit-hep/awkward#3043 (and subsequent changes to dask-awkward to defensively copy reports instead of changing them in place throughout a DAG)? Once the reports become effectively immutable from dask-awkward's point of view—that is, each DAG node is associated with an unchanging report—then we won't need to have a hierarchical structure, nesting reports, since we could make the output of I came to this from #456, since @gordonwatts hit the same issue again and I was checking up on it. |
|
I think this will become slightly simpler, but much of the logic will remain. The feature required by |
Fixes #456
It's clear from #456 that the complexity around
axis=0concatenation makes it hard to reason about!The bug is caused by the loss of
reportobjects associated with secondary arrays in the concatenate call; right now we take the first array (because all arrays are coerced to the same form) as the "meta".To fix this, we need to build a "parent" meta such that
parent.touch_data("key-1")invokeschild1.touch_data("key-1-child"),child2.touch_data("key-2-child"), and so on.I'll try and clean this up, probably with an Awkward fix, in the near future.