Remove calls to self.cluster.call_async()#456
Merged
jacobtomlinson merged 2 commits intodask:mainfrom Jun 7, 2025
Merged
Conversation
Contributor
|
Hey again @jacobtomlinson 👋 , Sorry for commenting on a merged PR, but after trying out this change in the Openstack provider, I found out that
I quickly tried to use and it seems to be working, but since I'm no expert on this topic, I wanted to know what you might think about this issue. |
Member
Author
|
Ah ok, can you open a new issue to track this? |
Contributor
|
Here; #460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the implementations of
VMInterfacecallself.cluster.call_async()when they want to run a synchronous function. This reference to the parent cluster instance means thatVMInterfaceinstances can't exist outside of a cluster.This PR adds a
VMInterface.call_asyncmethod which encapsulates the call toself.cluster.call_async(). This allows others to override this method if they wish more easily.