Conversation
phofl
left a comment
There was a problem hiding this comment.
Please open an issue clearly describing the problem and then add a test for your changes here. The current change is definitely incorrect since it will break existing stuff
I removed the last two rows. I don't know full library guts, so I can not correctly understand the logic behind the intended behavior. But the code clearly shows contradiction. Also, I have a specific example where these rows caused an infinite loop, but this is a rather specific case. If it is suitable, I can add a test for this case. |
|
the current logic definitely behaves as intended for what it was added for, there is no contradiction. Yes, please add an example that is failing / causing an infinite loop |
|
I see: |
In case of absent
modeparamater in the custom fsspec file system implementation removed rows caused infinite loop, as mentioned in comments several rows above