Handle Client(..., security=False)

[jacobtomlinson]

Currently the security kwarg of Client takes a few options:

• A Security object with certs loaded
• A dict of certs that get converted into a Security object
• True to auto generate certs
• None to skip using TLS (the default)

Given that it accepts a bool type this can cause confusion when passing False, which currently raises an exception #8973.

This PR makes security=False behave the same as security=None.

• Tests added / passed
• Passes pre-commit run --all-files

Closes #8973

[github-actions]

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ± 0      27 suites  ±0   11h 34m 25s ⏱️ - 2m 20s
 4 126 tests + 1   3 997 ✅ + 1    125 💤 ±0  3 ❌  - 1  1 🔥 +1 
51 704 runs  +14  49 269 ✅ +15  2 429 💤 ±0  5 ❌  - 2  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 58b1dfa. ± Comparison against base commit 8d8c878.

♻️ This comment has been updated with latest results.

[TomAugspurger]

LGTM. Only minor suggestion might be an assertion about c.security to make sure we get the expected thing. Something like assert c.security.require_encrpytion is False? But I suspect we already test that with security=None so not a big deal.

[jacobtomlinson]

Thanks for the review @TomAugspurger. That's a good suggestion, I've added that assertion.

[jacobtomlinson]

CI failures are related to #8936. I'm going to merge this based on @TomAugspurger's review.