SpecCluster: add option to *not* shut down the scheduler when the cluster is closed#9021
Merged
jacobtomlinson merged 3 commits intodask:mainfrom Mar 12, 2025
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 11h 43m 41s ⏱️ + 13m 48s For more details on these failures, see this check. Results for commit fa66395. ± Comparison against base commit 7df4356. ♻️ This comment has been updated with latest results. |
jacobtomlinson
approved these changes
Mar 12, 2025
Member
jacobtomlinson
left a comment
There was a problem hiding this comment.
This looks good to me. I think we will need to go through the various implementations of SpecCluster and set this value in cases where we also set shutdown_on_close=False.
…re/shutdown_scheduler_option
Member
|
Merged in from main to resolve CI issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
shutdown_scheduleroption toSpecCluster. Defaults toTrueso this is backward compatible.Closes SpecCluster implmentation closes the scheduler unexpectedly #7025
Closes AWS - ECS/Fargate Cluster - When providing a
scheduler_address, callingcluster.close()terminates the remote scheduler via tcp dask-cloudprovider#375Tests added / passed
Passes
pre-commit run --all-files