Return a default value if address resolution fails#9051
Return a default value if address resolution fails#9051jacobtomlinson merged 1 commit intodask:mainfrom
Conversation
If getaddrinfo() fails for whatever reason, return the default loopback address instead. This allows running tests on systems that are otherwise not connected to a network.
|
Fedora's build environment has always been restricted with regards to network. Recently, I noticed address resolution no longer working. That impacted the entire test suite, while the loopback adapter remains available. It turns out this builds on the work of a fellow Fedorian (#8712). The warning message should allow for dask's tests to pass (currently testing), which already has |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 3m 15s ⏱️ - 3m 59s For more details on these failures, see this check. Results for commit a9f2f39. ± Comparison against base commit 3f17ddb. |
jacobtomlinson
left a comment
There was a problem hiding this comment.
This looks reasonable to me. The CI failures appear to be unrelated.
If getaddrinfo() fails for whatever reason, return the default
loopback address instead. This allows running tests on systems
that are otherwise not connected to a network.