Skip to content

Clean up deprecated Prometheus metrics #9249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crusaderky wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −13
Open

Clean up deprecated Prometheus metrics #9249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions distributed/http/worker/prometheus/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,6 @@ def collect(self) -> Iterator[Metric]:
tasks.add_metric([state], n)
yield tasks

yield GaugeMetricFamily(
self.build_name("concurrent_fetch_requests"),
(
"Deprecated: This metric has been renamed to transfer_incoming_count.\n"
"Number of open fetch requests to other workers"
),
value=ws.transfer_incoming_count,
)

if self.server.monitor.monitor_gil_contention:
yield CounterMetricFamily(
self.build_name("gil_contention"),
Expand Down
1 change: 0 additions & 1 deletion distributed/http/worker/tests/test_worker_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ async def test_prometheus(c, s, a):
a.http_server.port, prefix="dask_worker_"
)
expected_metrics = {
"dask_worker_concurrent_fetch_requests",
"dask_worker_latency_seconds",
"dask_worker_memory_bytes",
"dask_worker_spill_bytes_total",
Expand Down
3 changes: 0 additions & 3 deletions docs/source/prometheus.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,6 @@ dask_worker_transfer_outgoing_count
Number of open data transfers to other workers
dask_worker_transfer_outgoing_count_total
Total number of data transfers to other workers since the worker was started
dask_worker_concurrent_fetch_requests
**Deprecated:** This metric has been renamed to
``dask_worker_transfer_incoming_count``.
dask_worker_tick_count_total
Total number of ticks observed since the server started
dask_worker_tick_duration_maximum_seconds
Expand Down
Loading