fix: address missing complex type in applicable function signatures
#905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
Maintenance
|
As this PR addresses a typing omission for already specified behavior per the v2022.12 revision of the Array API specification, I'll go ahead and merge. |
kgryte
changed the title
complex type in applicable function signaturescomplex type in applicable function signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
complexscalar argument support. This oversight has already been addressed in the current draft (see feat: add scalar support to element-wise functions #862). This PR backports the changes to previous revisions of the specification.__or__specification in the v2022.12 revision of the standard. It currently says that complex dtype support was added for this API, but this is not correct.__eq__as to when complex dtype support was added.