Skip to content

apply codecommit:GitPull permission properly #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petrkalos merged 1 commit into from
Dec 12, 2025
Merged

apply codecommit:GitPull permission properly #1887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion deploy/stacks/pipeline.py
View file
Open in desktop
Copy link

@wliu03 wliu03 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the resource include {self.region}:{self.account}

Copy link
Contributor Author

@petrkalos petrkalos Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it but people might have their repo in a different region and not necessarily in the same that data.all is deployed to.

Copy link

@wliu03 wliu03 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, looks good to me, thanks for the code change

Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,6 @@ def set_codebuild_iam_roles(self):
'codeartifact:GetAuthorizationToken',
'codeartifact:GetRepositoryEndpoint',
'codeartifact:ReadFromRepository',
'codecommit:GitPull',
'ecr:GetDownloadUrlForLayer',
'ecr:BatchGetImage',
'ecr:BatchCheckLayerAvailability',
Expand Down Expand Up @@ -398,6 +397,15 @@ def set_codebuild_iam_roles(self):
resources=[self.repo_connection_arn],
),
)
else:
baseline_policy_statements.append(
iam.PolicyStatement(
actions=[
'codecommit:GitPull',
],
resources=[f'arn:aws:codecommit:*:{self.account}:dataall'],
)
)

self.baseline_codebuild_policy = iam.ManagedPolicy(
self,
Expand Down
Loading