e2e tests PostgreSql Sink #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitCLI
force-pushed
the
e2e-postgresql-sink
branch
from
096ae48 to
0c1f6f0
Compare
| } | ||
|
|
||
| @After(order = 1, value = "@CONNECTION") | ||
| public static void deleteBQConnection() throws IOException { |
There was a problem hiding this comment.
why is this method named deleteBQConnection?
AnkitCLI
force-pushed
the
e2e-postgresql-sink
branch
from
0c1f6f0 to
4cdb1a5
Compare
| Then Replace input plugin property: "password" with value: "password" for Credentials and Authorization related fields | ||
| Then Enter input plugin property: "referenceName" with value: "targetRef" | ||
| Then Replace input plugin property: "dbSchemaName" with value: "schema" | ||
| Then Select radio button plugin property: "opeationName" with value: "UPDATE" |
There was a problem hiding this comment.
can't we just parameterize this test?
This one and upsert one has only one difference
AnkitCLI
force-pushed
the
e2e-postgresql-sink
branch
2 times, most recently
from
d4cd1dc to
8d00f50
Compare
| Then Replace input plugin property: "password" with value: "password" for Credentials and Authorization related fields | ||
| Then Enter input plugin property: "referenceName" with value: "targetRef" | ||
| Then Replace input plugin property: "dbSchemaName" with value: "schema" | ||
| Then Select radio button plugin property: "opeationName" with value: "<options>" |
There was a problem hiding this comment.
Is this property name correct opeationName?
There was a problem hiding this comment.
changed to operationName
AnkitCLI
force-pushed
the
e2e-postgresql-sink
branch
3 times, most recently
from
130c4c2 to
0ae7154
Compare
AnkitCLI
force-pushed
the
e2e-postgresql-sink
branch
8 times, most recently
from
c5a3d26 to
7c070bb
Compare
AnkitCLI
force-pushed
the
e2e-postgresql-sink
branch
from
7c070bb to
b68a986
Compare
itsankit-google
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists additional e2e test scenarios for Postgresql Sink Plugin