Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39c7a44236
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
cli/tests/00-basa.sql
Outdated
| @@ -0,0 +1,7 @@ | |||
| select 1 | |||
There was a problem hiding this comment.
cli/test.sh pipes this file into bendsql in non-interactive mode, where statement splitting depends on sql_delimiter (;) in SqlParser::parse_line/parse_statements (cli/src/sql_parser.rs), and any trailing buffer is executed once at EOF (cli/src/session.rs:444-449). Without a ; after select 1, the parser keeps buffering through the comment block and select 2, so the client sends one combined query instead of two statements, which breaks the expected 00-basa.result output (1 then 2).
Useful? React with 👍 / 👎.
1 participant
No description provided.