Skip to content

chore(task): validate set settings name on alter taks set #17860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2025

Conversation

flaneur2020
Copy link
Member

@flaneur2020 flaneur2020 commented Apr 28, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fixes #17808

Tests

  • Logic Test

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 28, 2025
@flaneur2020 flaneur2020 changed the title chore: validate set settings name on alter taks set chore(task): validate set settings name on alter taks set Apr 28, 2025
@flaneur2020 flaneur2020 marked this pull request as ready for review April 28, 2025 08:28
@BohuTANG
Copy link
Member

BohuTANG commented May 6, 2025

0: statement failed: Databend sqllogictests error: http query error: code: 2801, Text: Unknown variable: "database"
[SQL] ALTER TASK sessionTask
SET
DATABASE = 'db2', TIMEZONE = 'Pacific/Honolulu'
at tests/sqllogictests/suites/task/task_ddl_test.test:126

Error: SelfError("sqllogictest failed")

@flaneur2020 flaneur2020 force-pushed the chore/add-checks-about-settings-names branch from 71d9227 to d552af7 Compare May 6, 2025 09:50
@BohuTANG
Copy link
Member

BohuTANG commented May 7, 2025

The failed test is not related to this PR, let's merge.

@BohuTANG BohuTANG merged commit 3047dc1 into main May 7, 2025
128 of 152 checks passed
@BohuTANG BohuTANG deleted the chore/add-checks-about-settings-names branch May 7, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: validate keys in "ALTER TASK .. SET [key] = [val]" statment
2 participants