Skip to content

fix: avoid excessive concurrency in row fetch #17885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented May 6, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Use semaphore to limit the concurrency of row fetch to avoid OOM.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - current tests should cover

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label May 6, 2025
@SkyFan2002 SkyFan2002 marked this pull request as ready for review May 6, 2025 15:58
@SkyFan2002 SkyFan2002 requested a review from zhang2014 May 6, 2025 15:58
@SkyFan2002 SkyFan2002 marked this pull request as draft May 7, 2025 02:46
@KKould
Copy link
Member

KKould commented May 7, 2025

Please update branch to synchronize #17887 to solve ci fail

@SkyFan2002 SkyFan2002 changed the title feat: drop unused rows as early as possible during row fetch fix: avoid excessive concurrency in row fetch May 7, 2025
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label May 7, 2025
@SkyFan2002 SkyFan2002 marked this pull request as ready for review May 7, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants