Skip to content

refactor(meta-embedded): remove embedded meta-store #17888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented May 7, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(meta-embedded): remove embedded meta-store

Replace embedded testing meta-service with standalone process.

The MemMeta and MemStateMachine implementations were previously used
for providing an embedded version of databend-meta service for testing.
This approach required maintaining two separate versions of meta-service,
creating long-term maintenance overhead.

Testing now uses a standalone databend-meta process running on a random
port and temporary directory. This change unifies our meta-service
implementation and eliminates the duplicated maintenance burden.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Other

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label May 7, 2025
@drmingdrmer drmingdrmer marked this pull request as ready for review May 7, 2025 06:52
Replace embedded testing meta-service with standalone process.

The `MemMeta` and `MemStateMachine` implementations were previously used
for providing an embedded version of `databend-meta` service for testing.
This approach required maintaining two separate versions of meta-service,
creating long-term maintenance overhead.

Testing now uses a standalone databend-meta process running on a random
port and temporary directory. This change unifies our meta-service
implementation and eliminates the duplicated maintenance burden.
@drmingdrmer drmingdrmer merged commit 2b6aca0 into databendlabs:main May 7, 2025
76 of 77 checks passed
@drmingdrmer drmingdrmer deleted the 307-rm-mem-meta branch May 7, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant