Skip to content

refactor: refine system history tables and add login table #17937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 1, 2025
Merged

refactor: refine system history tables and add login table #17937

merged 5 commits into from
Jun 1, 2025

Conversation

dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented May 15, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Refactor history tables to enable concurrent data extraction from multiple tables.
  2. Update the COPY INTO sql for retrieving all Parquet files in the stage(also purged), instead of relying on the list.
  3. Add a Login table.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label May 15, 2025
zhang2014
zhang2014 reviewed May 19, 2025
View reviewed changes
src/query/service/src/servers/http/middleware/session.rs
@@ -341,9 +344,19 @@ fn make_cookie(name: impl Into<String>, value: impl Into<String>) -> Cookie {

impl<E> HTTPSessionEndpoint<E> {
#[async_backtrace::framed]
async fn auth(&self, req: &Request, query_id: String) -> Result<HttpQueryContext> {
let credential = get_credential(req, self.kind, self.endpoint_kind)?;
async fn auth(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help review. @TCeason @youngsofun

zhang2014
zhang2014 reviewed May 19, 2025
View reviewed changes
@dqhl76 dqhl76 force-pushed the config-log-table branch from ae9bb4b to d8f2c29 Compare May 19, 2025 07:29
@youngsofun
Copy link
Member

what is the purpose of adding login table?

@dqhl76
Copy link
Collaborator Author

dqhl76 commented May 19, 2025 •
edited
Loading

what is the purpose of adding login table?

I think may be used for auditing or compliance? I only know a user need it. It is not enabled in default.

@dqhl76 dqhl76 force-pushed the config-log-table branch from 329fefd to a41be83 Compare May 23, 2025 06:06
@dqhl76 dqhl76 closed this May 26, 2025
@dqhl76 dqhl76 deleted the config-log-table branch May 26, 2025 02:52
@dqhl76 dqhl76 restored the config-log-table branch May 26, 2025 02:52
@dqhl76 dqhl76 reopened this May 26, 2025
@dqhl76 dqhl76 force-pushed the config-log-table branch from a41be83 to 54e0ef4 Compare May 28, 2025 04:52
@dqhl76 dqhl76 force-pushed the config-log-table branch from 54e0ef4 to 04f5733 Compare May 28, 2025 07:21
@dqhl76 dqhl76 added the ci-benchmark Benchmark: run all test label May 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17937-c0a34e1-1748420181

note: this image tag is only available for internal use.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

dqhl76 added 2 commits May 28, 2025 20:06
@dqhl76 dqhl76 marked this pull request as ready for review May 29, 2025 12:36
@dqhl76 dqhl76 requested a review from zhang2014 May 29, 2025 12:36
zhang2014
zhang2014 approved these changes Jun 1, 2025
View reviewed changes
Copy link
Member

@zhang2014 zhang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please provide the relevant documentation and examples.

@zhang2014 zhang2014 merged commit 5f8381e into databendlabs:main Jun 1, 2025
149 of 153 checks passed
@zhang2014 zhang2014 mentioned this pull request Jun 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dqhl76 @youngsofun @zhang2014