feat: Use query id as trace id #17947
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Use the same ID for both the query ID and the trace ID.
The OTEL specification requires the trace ID to be 128 bits (32 hex chars). To enable us to use our query ID as the trace ID, I have changed the format of our query ID from
67e55044-10b1-426f-9247-bb680e5fe0c8
to67e5504410b1426f9247bb680e5fe0c8
.I believe this should be a non-breaking change, as it is unlikely that any system depends on the specific representation of the query ID. However, we should still review this carefully to ensure we haven't introduced any unexpected issues.
Tests
Type of change
This change is