Skip to content

chore: enable Lz4Raw for parquet reading compatibility #17959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented May 19, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore: enable Lz4Raw for parquet reading compatibility

Re-enable Lz4Raw compression support for the data written by legacy databend-query in the reading path
to maintain compatibility with existing objects that were compacted with parquet Lz4Raw (but marked as databend LZ4 previously).

Note: The writing path remains unchanged - no new Lz4Raw compressed data will be generated.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Test manually

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Re-enable Lz4Raw compression support in the reading path to maintain
compatibility with existing objects that were compacted with parquet Lz4Raw.

Note: The writing path remains unchanged - no new Lz4Raw compressed data
will be generated.
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label May 19, 2025
@dantengsky dantengsky requested review from SkyFan2002 and wubx May 20, 2025 03:40
@dantengsky dantengsky marked this pull request as ready for review May 20, 2025 03:41
@BohuTANG BohuTANG merged commit 668b9b7 into databendlabs:main May 20, 2025
155 of 157 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants