Skip to content

feat: Implement Modify Table Connection #18034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 3, 2025

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 29, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR adds the support for Modify Table Connection.

One uncommon but possible scenario is that users may want to update the connection settings for an external table. For instance, their AK/SK credentials might need to be rotated, or the role_arn could change. This PR adds support for such updates.

CREATE OR REPLACE TABLE external_table_test (
    id INTEGER,
    name VARCHAR,
    age INT
) 
's3://testbucket/13_fuse_external_table/' 
CONNECTION=(connection_name = 'external_table_conn');

ALTER TABLE external_table_test CONNECTION=( connection_name = 'external_table_conn_new' );

Only credential-related settings such as access_key_id or secret_access_key can be changed. Any changes to bucket, region, or root will be safely ignored.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label May 29, 2025
@BohuTANG BohuTANG requested a review from TCeason May 29, 2025 06:46
@Xuanwo Xuanwo force-pushed the alter-table-connection branch from 85e58c0 to 5cc82f0 Compare May 29, 2025 07:16
@BohuTANG BohuTANG merged commit cd45b2d into databendlabs:main Jun 3, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants