Skip to content

refactor: table branch refactor#19499

Draft
zhyass wants to merge 1 commit intodatabendlabs:mainfrom
zhyass:feat_branch
Draft

refactor: table branch refactor#19499
zhyass wants to merge 1 commit intodatabendlabs:mainfrom
zhyass:feat_branch

Conversation

@zhyass
Copy link
Member

@zhyass zhyass commented Mar 1, 2026 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhyass zhyass requested a review from drmingdrmer as a code owner March 1, 2026 16:37
@zhyass zhyass marked this pull request as draft March 1, 2026 16:37
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 1, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 1, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28e1e3fb14

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@zhyass zhyass force-pushed the feat_branch branch 9 times, most recently from d7fb7db to 1a79b69 Compare March 7, 2026 16:32
@zhyass
Copy link
Member Author

zhyass commented Mar 7, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 7, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a79b69799

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/meta/api/src/api_impl/garbage_collection_api.rs Outdated
Comment on lines +215 to +219
} else {
warn!(
"gc_dropped_branch_by_id: branch history cleanup txn not committed, table_id={}, branch_name={}, branch_id={}",
req.table_id, req.branch_name, req.branch_id
);
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Retry failed branch-history cleanup instead of returning success

When the history-update transaction is not committed, this path only logs and still returns Ok, even though branch metadata was already removed earlier in the function. Under concurrent branch recreation (history seq changes), that leaves stale branch IDs in __fd_branch_id_list; and because list_history_table_branches skips entries whose TableMeta is already gone, later vacuum passes may never revisit that ID to clean it up. This can leave permanent metadata drift and unbounded history-key growth for active tables.

Useful? React with 👍 / 👎.

@zhyass zhyass force-pushed the feat_branch branch 2 times, most recently from 88c3471 to e6d9624 Compare March 11, 2026 17:20
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026 •
edited
Loading

🤖 CI Job Analysis

Workflow: 23017642048

📊 Summary

  • Total Jobs: 85
  • Failed Jobs: 3
  • Retryable: 0
  • Code Issues: 3

❌ NO RETRY NEEDED

All failures appear to be code/test issues requiring manual fixes.

🔍 Job Details

  • ❌ linux / test_unit: Not retryable (Code/Test)
  • ❌ linux / test_ee_standalone: Not retryable (Code/Test)
  • ❌ linux / sqllogic / ee (parquet): Not retryable (Code/Test)
🤖 About

Automated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed).

@zhyass zhyass mentioned this pull request Mar 12, 2026
Merged
11 tasks
@zhyass
update
ed5be2c 
update

add test

update

update

update

fix test

update

update

update

fix test

update

update

update

update

update

update

update

update

update

update

update

update

update

update

update

update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@drmingdrmer drmingdrmer Awaiting requested review from drmingdrmer drmingdrmer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zhyass