Skip to content

fix(query): support table index privilege checks#20124

Open
TCeason wants to merge 1 commit into
databendlabs:mainfrom
TCeason:index_priv
Open

fix(query): support table index privilege checks#20124
TCeason wants to merge 1 commit into
databendlabs:mainfrom
TCeason:index_priv

Conversation

@TCeason

@TCeason TCeason commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Allow table index create, refresh, and drop operations with target table ALTER access or ownership, while preserving GLOBAL SUPER as a compatibility fallback.

Document the scoped table-index privilege model and add RBAC coverage for denied, ALTER, database owner, and SUPER cases.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions Bot added the pr-bugfix this PR patches a bug in codebase label Jul 8, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bed86e8e3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/query/service/src/interpreters/access/privilege_access.rs Outdated
@TCeason

TCeason commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 19f5309e90

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Allow table index create, refresh, and drop operations with target table ALTER access or ownership, while preserving GLOBAL SUPER as a compatibility fallback.

Document the scoped table-index privilege model and add RBAC coverage for denied, ALTER, database owner, and SUPER cases.
@TCeason
TCeason requested review from KKould, b41sh and wubx July 9, 2026 04:27
@wubx

wubx commented Jul 9, 2026

Copy link
Copy Markdown
Member

LGTM

@b41sh
b41sh added this pull request to the merge queue Jul 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants