refactor(query): combine short-query and page-aware execution#20176
Draft
dbsid wants to merge 15 commits into
Draft
refactor(query): combine short-query and page-aware execution#20176dbsid wants to merge 15 commits into
dbsid wants to merge 15 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Draft integration PR for the reviewed changes in #20165 and #20166.
This branch combines:
The purpose of this draft is to continue profiling the combined path and reduce the 5-concurrent p99 latency of Q1, Q2, and Flex below 10 ms. The target is not claimed yet: the prior #20166 c5 lazy benchmark reached p99 values of 34.66, 38.68, and 39.57 ms for Q1, Q2, and Flex respectively.
Composition
origin/mainat7dc41477f7.b934267071ea7c77cac027e63f7d56950844108b.643c2fc22b2452be6e2400068e1c8f93766f9d3d.Benchmark Contract
Driver: https://github.com/dbsid/hbx-web3
i4i.4xlarge, single query node, S3 inus-west-2, native release build;lazy_read_threshold=1000;2026071305,max_threads=2,max_storage_io_requests=16;lazy_read_threshold=0are required for every claimed result.Profiling Plan
Current Validation
git diff --checkpasses.Tests
Type of change
This change is