Skip to content

refactor(query): split datetime helpers by responsibility#20190

Open
forsaken628 wants to merge 1 commit into
databendlabs:mainfrom
forsaken628:refactor-date-helper
Open

refactor(query): split datetime helpers by responsibility#20190
forsaken628 wants to merge 1 commit into
databendlabs:mainfrom
forsaken628:refactor-date-helper

Conversation

@forsaken628

@forsaken628 forsaken628 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Move shared Date and Timestamp conversion primitives into their owning expression type modules and remove the cross-layer date_helper utility.
  • Split the monolithic datetime implementation into focused arithmetic, conversion, extraction, formatting, rounding, and time-slice modules.
  • Update formatting, interval, window, dictionary, and task-history consumers to use the new APIs while preserving existing date-boundary and timezone behavior.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions Bot added the pr-refactor this PR changes the code base without new features or bugfix label Jul 22, 2026
@forsaken628
forsaken628 marked this pull request as ready for review July 23, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant