chore(deps): bump thrift from 0.17.0 to 0.23.0#20196
Conversation
Bumps [thrift](https://github.com/apache/thrift) from 0.17.0 to 0.23.0. - [Release notes](https://github.com/apache/thrift/releases) - [Changelog](https://github.com/apache/thrift/blob/master/CHANGES.md) - [Commits](apache/thrift@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: thrift dependency-version: 0.23.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
At least one test kind must be checked in the PR description. |
|
Pull request description must contain CLA like the following: |
|
At least one type of change must be checked in the PR description. |
|
Sorry, only users with push access can use that command. |
3 similar comments
|
Sorry, only users with push access can use that command. |
|
Sorry, only users with push access can use that command. |
|
Sorry, only users with push access can use that command. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf854aa81c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "tantivy-fst", | ||
| "tantivy-jieba", | ||
| "thrift", | ||
| "thrift 0.23.0", |
There was a problem hiding this comment.
Keep fuse's thrift version aligned with parquet
In databend-common-storages-fuse, src/query/storages/fuse/src/table_functions/fuse_page.rs combines parquet::thrift::TSerializable with thrift::protocol::TCompactInputProtocol when reading PageHeaders. After this split, the fuse crate gets thrift 0.23.0 here while parquet 58.1.0 is still locked to thrift 0.17.0, so the protocol type no longer implements the TInputProtocol trait expected by parquet's generated PageHeader::read_from_in_protocol. This breaks builds that include the fuse storage crate; either use parquet's re-exported thrift protocol in that code path or keep the thrift versions unified.
Useful? React with 👍 / 👎.
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
Bumps thrift from 0.17.0 to 0.23.0.
Release notes
Sourced from thrift's releases.
Changelog
Sourced from thrift's changelog.
... (truncated)
Commits
c4cbe43Address vulnerabilities in Rack68ac8e9Enable TLS hostname verification in TNonblockingSSLSocket5e4f01dHarden Node.js WebSocket server handlinge242889Add input validation to Swift protocol layer4af8c7cAdd recursion depth limit to Node.js protocol skip()a30c552Enable TLS hostname verification in TSSLTransportFactory276ec88THRIFT-5929: Fix build failure on PHP 8.5 due to removed zend_exception_get_d...df52ad4EXTRA_DIST fixes21a89c6build fixes630d66cadded int range checksDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
This change is