Skip to content

fix: pass providerConfig envVars to startPanel on session creation#105

Merged
everpcpc merged 1 commit intodatabendlabs:mainfrom
everpcpc:belgrade-wy1sncef
Feb 10, 2026
Merged

fix: pass providerConfig envVars to startPanel on session creation#105
everpcpc merged 1 commit intodatabendlabs:mainfrom
everpcpc:belgrade-wy1sncef

Conversation

@everpcpc
Copy link
Member

Summary

Provider ENV settings configured in Settings (providerConfigs.{claude,codex,gemini,kimi}.envVars) were not applied when a session was first created. They only took effect on subsequent messages (the panels:continue path).

The root cause was that TaskQueue.ts did not call readProviderConfig() when invoking startPanel() for any of the four providers, while session.ts correctly did so in the panels:continue handler.

This fix:

  • Exports readProviderConfig from session.ts
  • Imports it in TaskQueue.ts and passes providerConfig to all four startPanel calls (Claude, Codex, Gemini, Kimi)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Two-line plumbing fix passing an existing config to existing callsites; covered by manual verification

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

readProviderConfig was only called in the panels:continue path but
missing from all four startPanel calls in TaskQueue, so provider ENV
settings had no effect on the initial spawn.
@everpcpc everpcpc marked this pull request as ready for review February 10, 2026 10:01
@everpcpc everpcpc merged commit 1174a59 into databendlabs:main Feb 10, 2026
3 checks passed
@everpcpc everpcpc deleted the belgrade-wy1sncef branch February 10, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments