Fix collapse-all trigger causing newly mounted items to auto-collapse#111
Merged
everpcpc merged 1 commit intodatabendlabs:mainfrom Feb 13, 2026
Merged
Fix collapse-all trigger causing newly mounted items to auto-collapse#111everpcpc merged 1 commit intodatabendlabs:mainfrom
everpcpc merged 1 commit intodatabendlabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When clicking "Collapse Diff" or "Collapse All", the
collapseAllTriggercounter increments. Components checkedcollapseAllTrigger > 0in auseEffectto decide whether to collapse. However, when new items (diffs, tool calls, thinking blocks) mounted after the button was clicked, they saw the trigger was already > 0 and auto-collapsed on mount.Fixed by capturing the trigger value at mount time via
useRefand only reacting to values greater than the initial one. This makes collapse a one-time operation that only affects currently mounted items.Files changed:
InlineDiffViewer.tsx— inline diffs in timelineToolCallMessage.tsx— tool call entriesThinkingMessage.tsx— thinking blocksTimelineView.tsx—AgentResponsecomponentTests
Type of change