chore: tune tsdown configuration to reduce bundle size#5
Merged
Conversation
fjakobs
force-pushed
the
improve-bundle-size
branch
from
72e92ff to
c04265c
Compare
Modified the external function in tsdown configs to properly handle @/ path aliases: - Added check to prevent @/ imports from being treated as external dependencies - This allows tsdown to resolve these paths to actual file paths during bundling - Applied to both @databricks/app-kit and @databricks/app-kit-ui packages The issue was that the regex /^[^./]/ was marking all non-relative imports (including @/ aliases) as external, preventing proper resolution. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Fabian Jakobs <fabian.jakobs@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced bundle size dramatically by not bundling node dependencies.
Before:
After: