Fix : [ISSUE] databricks auth login - Invalid Databricks Account configuration when host does not specify scheme #1403 #1196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR addresses an issue where the Databricks authentication process fails when the host URL does not explicitly include the https:// scheme.
WHAT
The following changes were made:
IsAccountClient
function in[./config/config.go](config/config.go)
to account for host URLs without thehttps://
scheme (e.g.,accounts.cloud.databricks.com
).https://
scheme.https://
scheme.WHY
Previously, the authentication failed for users who did not specify https:// in their host URL, even though this should have been allowed. The change ensures that authentication works seamlessly even when the URL is missing the scheme, avoiding unnecessary errors.
How is this tested?
Added unit tests functions in
[./config/config_test.go](config/config_test.go)
to validate the changes:TestIsAccountClient_WithoutHTTPSInHost_AWSAccount
: Validates that the IsAccountClient function works for AWS accounts without the https:// scheme.TestIsAccountClient_WithoutHTTPSInHost_AwsDodAccount
: Tests the same functionality for AWS DOD accounts.After:
Before: