Skip to content

Fix debug logs showing empty Host for API requests #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hectorcast-db wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix debug logs showing empty Host for API requests #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d795e61
Fix debug logs showing empty Host for API requests
hectorcast-db Mar 9, 2026
f80d2af
Only set r.Host when not already set
hectorcast-db Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bug Fixes

- Fix debug logs showing empty `Host` for API requests.

### Documentation

### Internal Changes
Expand Down
9 changes: 9 additions & 0 deletions config/api_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,17 @@ func HTTPClientConfigFromConfig(cfg *Config) (httpclient.ClientConfig, error) {
if err != nil {
return err
}
// API requests are made with relative paths (e.g. /api/2.0/...).
// r.URL.Host and r.URL.Scheme direct the HTTP client to the right
// server. r.Host sets the Host header explicitly; if r.Host is
// empty, Go copies r.URL.Host into the Host header automatically
// before sending, so both reach the same server — but leaving
// r.Host empty makes debug logs misleadingly show an empty host.
r.URL.Host = url.Host
r.URL.Scheme = url.Scheme
if r.Host == "" {
r.Host = url.Host
}
return nil
},
authInUserAgentVisitor(cfg),
Expand Down
Loading